[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-test-1603-gc8def55

[Volker Lendecke]

The branch, v3-2-test has been updated
       via  c8def5564739c4c754001f84fcfb77f1093b96c3 (commit)
      from  196e4ce8c5dd5aab518aaa7d170eb1fb5d66bcd1 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit c8def5564739c4c754001f84fcfb77f1093b96c3
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 22 09:13:25 2008 +0100

    Fix a segfault
    
    Found by the IBM checker.
    
    Jeremy, you changed this from 'dirname == 0' which does not make sense at all
    in the old code to '!dirname == 0' which from my point of view makes even less
    sense, because the precedence of ! is according to Harbison/Steele higher than
    the precedence of ==. Please check that the code now actually does what it's
    supposed to do.
    
    Thanks!

-----------------------------------------------------------------------

Summary of changes:
 source/smbd/utmp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/smbd/utmp.c b/source/smbd/utmp.c
index e82bbea..5931b2b 100644
--- a/source/smbd/utmp.c
+++ b/source/smbd/utmp.c
@@ -223,7 +223,7 @@ static char *uw_pathname(TALLOC_CTX *ctx,
 	}
 
 	/* For u-files and non-explicit w-dir, look for "utmp dir" */
-	if (!dirname == 0 || strlen(dirname) == 0) {
+	if ((dirname == NULL) || (strlen(dirname) == 0)) {
 		dirname = talloc_strdup(ctx, lp_utmpdir());
 		if (!dirname) {
 			return NULL;


-- 
Samba Shared Repository