[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-1297-g0d2c77e

Jeremy Allison jra at samba.org
Sat Jan 12 07:29:52 GMT 2008


The branch, v3-2-test has been updated
       via  0d2c77e8d3a83f2c5e78fa076f22919ef9d124b9 (commit)
       via  05cadffeab38ca9df7ffd46785b536266c4438c4 (commit)
      from  a5cd3c9b65538588a6c982c6d20022e7476cf3de (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 0d2c77e8d3a83f2c5e78fa076f22919ef9d124b9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Jan 11 23:17:23 2008 -0800

    Fix CID 505 - don't copy uninitialized memory.
    Jeremy.

commit 05cadffeab38ca9df7ffd46785b536266c4438c4
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Jan 11 22:50:13 2008 -0800

    Fix CID 523 - wrong null deref check.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source/smbd/mangle_hash2.c |    2 +-
 source/smbd/notify.c       |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/smbd/mangle_hash2.c b/source/smbd/mangle_hash2.c
index 9643506..a9b94aa 100644
--- a/source/smbd/mangle_hash2.c
+++ b/source/smbd/mangle_hash2.c
@@ -396,7 +396,7 @@ static bool lookup_name_from_8_3(TALLOC_CTX *ctx,
 
 	TALLOC_FREE(prefix);
 
-	if (!pp_out) {
+	if (!*pp_out) {
 		M_DEBUG(0,("talloc_fail"));
 		return False;
 	}
diff --git a/source/smbd/notify.c b/source/smbd/notify.c
index 5c26cac..55009ce 100644
--- a/source/smbd/notify.c
+++ b/source/smbd/notify.c
@@ -235,6 +235,7 @@ NTSTATUS change_notify_create(struct files_struct *fsp, uint32 filter,
 		return NT_STATUS_NO_MEMORY;
 	}
 
+	ZERO_STRUCT(e);
 	e.path = fullpath;
 	e.filter = filter;
 	e.subdir_filter = 0;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list