[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-1228-gd7a7b79

Michael Adam obnox at samba.org
Wed Jan 9 21:10:33 GMT 2008


The branch, v3-2-test has been updated
       via  d7a7b793203b986823859ac5171d2d4c30e52415 (commit)
      from  e73e3da772bd024f1d74fc41b832f181ba5c43bd (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit d7a7b793203b986823859ac5171d2d4c30e52415
Author: Michael Adam <obnox at samba.org>
Date:   Wed Jan 9 22:09:55 2008 +0100

    Fix memleak in ldapsam_rename_sam_account() found by IBM checker.
    
    The check for out of memory was the wrong way round.
    
    Michael

-----------------------------------------------------------------------

Summary of changes:
 source/passdb/pdb_ldap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/passdb/pdb_ldap.c b/source/passdb/pdb_ldap.c
index 28df56b..90a6ff0 100644
--- a/source/passdb/pdb_ldap.c
+++ b/source/passdb/pdb_ldap.c
@@ -1973,7 +1973,7 @@ static NTSTATUS ldapsam_rename_sam_account(struct pdb_methods *my_methods,
 
 	/* rename the posix user */
 	rename_script = SMB_STRDUP(lp_renameuser_script());
-	if (rename_script) {
+	if (rename_script == NULL) {
 		return NT_STATUS_NO_MEMORY;
 	}
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list