[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-1212-gacfb233

Jeremy Allison jra at samba.org
Wed Jan 9 02:56:54 GMT 2008


The branch, v3-2-test has been updated
       via  acfb233acc7324b8d431d5cb777a1933d173b3dc (commit)
      from  9cd30fb25c42e79946b5140994d0bf2ef4c62f90 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit acfb233acc7324b8d431d5cb777a1933d173b3dc
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Jan 8 18:44:19 2008 -0800

    Fix resource leak found by coverity (CID 521).
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source/smbd/reply.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/smbd/reply.c b/source/smbd/reply.c
index 27f380a..a796a31 100644
--- a/source/smbd/reply.c
+++ b/source/smbd/reply.c
@@ -6355,6 +6355,7 @@ void reply_copy(struct smb_request *req)
 					directory,
 					dname);
 			if (!fname) {
+				CloseDir(dir_hnd);
 				reply_nterror(req, NT_STATUS_NO_MEMORY);
 				END_PROFILE(SMBcopy);
 				return;
@@ -6365,6 +6366,7 @@ void reply_copy(struct smb_request *req)
 				continue;
 			}
 			if (!destname) {
+				CloseDir(dir_hnd);
 				reply_nterror(req, NT_STATUS_NO_MEMORY);
 				END_PROFILE(SMBcopy);
 				return;
@@ -6372,6 +6374,7 @@ void reply_copy(struct smb_request *req)
 
 			status = check_name(conn, fname);
 			if (!NT_STATUS_IS_OK(status)) {
+				CloseDir(dir_hnd);
 				reply_nterror(req, status);
 				END_PROFILE(SMBcopy);
 				return;
@@ -6379,6 +6382,7 @@ void reply_copy(struct smb_request *req)
 
 			status = check_name(conn, destname);
 			if (!NT_STATUS_IS_OK(status)) {
+				CloseDir(dir_hnd);
 				reply_nterror(req, status);
 				END_PROFILE(SMBcopy);
 				return;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list