[SCM] Samba Shared Repository - branch v4-0-test updated - release-4-0-0alpha2-800-g0c5539e

[Stefan Metzmacher]

The branch, v4-0-test has been updated
       via  0c5539e5fedd4123f61d50ee29acdc5a5f0faf76 (commit)
       via  3ec4bce0b64764e364aedea2800eed296805c51e (commit)
      from  a496abc4042a98835d485769e0972826da161984 (commit)

http://gitweb.samba.org/?samba.git;a=shortlog;h=v4-0-test


- Log -----------------------------------------------------------------
commit 0c5539e5fedd4123f61d50ee29acdc5a5f0faf76
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Feb 13 16:20:23 2008 +0100

    torture/eventlog: the NTSTATUS of dcerpc_ functions is the same as r.out.result
    
    metze

commit 3ec4bce0b64764e364aedea2800eed296805c51e
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Feb 13 14:52:53 2008 +0100

    torture/eventlog: fix crash bugs!
    
    This bug was introduced in 92b8bde561277a6b83048ce003cc29ff1b380255
    and this shows that we need to be very, very careful in changing
    idl elements from scalars to [ref] pointers!
    
    metze

-----------------------------------------------------------------------

Summary of changes:
 source/torture/rpc/eventlog.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/torture/rpc/eventlog.c b/source/torture/rpc/eventlog.c
index 047146e..feeeb93 100644
--- a/source/torture/rpc/eventlog.c
+++ b/source/torture/rpc/eventlog.c
@@ -67,11 +67,14 @@ static bool test_GetNumRecords(struct torture_context *tctx, struct dcerpc_pipe
 	struct eventlog_GetNumRecords r;
 	struct eventlog_CloseEventLog cr;
 	struct policy_handle handle;
+	uint32_t number = 0;
 
 	if (!get_policy_handle(tctx, p, &handle))
 		return false;
 
+	ZERO_STRUCT(r);
 	r.in.handle = &handle;
+	r.out.number = &number;
 
 	torture_assert_ntstatus_ok(tctx, 
 			dcerpc_eventlog_GetNumRecords(p, tctx, &r), 
@@ -98,6 +101,7 @@ static bool test_ReadEventLog(struct torture_context *tctx,
 	if (!get_policy_handle(tctx, p, &handle))
 		return false;
 
+	ZERO_STRUCT(r);
 	r.in.offset = 0;
 	r.in.handle = &handle;
 	r.in.flags = EVENTLOG_BACKWARDS_READ|EVENTLOG_SEQUENTIAL_READ;
@@ -107,11 +111,15 @@ static bool test_ReadEventLog(struct torture_context *tctx,
 		struct eventlog_Record rec;
 		struct ndr_pull *ndr;
 		enum ndr_err_code ndr_err;
+		uint32_t sent_size = 0;
+		uint32_t real_size = 0;
 
 		/* Read first for number of bytes in record */
 
 		r.in.number_of_bytes = 0;
 		r.out.data = NULL;
+		r.out.sent_size = &sent_size;
+		r.out.real_size = &real_size;
 
 		status = dcerpc_eventlog_ReadEventLogW(p, tctx, &r);
 
@@ -119,8 +127,6 @@ static bool test_ReadEventLog(struct torture_context *tctx,
 			break;
 		}
 
-		torture_assert_ntstatus_ok(tctx, status, "ReadEventLog failed");
-
 		torture_assert_ntstatus_equal(tctx, r.out.result, NT_STATUS_BUFFER_TOO_SMALL,
 			"ReadEventLog failed");
 		


-- 
Samba Shared Repository