[SCM] Samba Shared Repository - branch v4-0-test updated - release-4-0-0alpha2-798-ga496abc

Stefan Metzmacher metze at samba.org
Wed Feb 13 12:19:16 GMT 2008


The branch, v4-0-test has been updated
       via  a496abc4042a98835d485769e0972826da161984 (commit)
      from  5100452cf3b3c3c5dcdb77a9efe27e8c506d1d43 (commit)

http://gitweb.samba.org/?samba.git;a=shortlog;h=v4-0-test


- Log -----------------------------------------------------------------
commit a496abc4042a98835d485769e0972826da161984
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Feb 13 13:04:54 2008 +0100

    pidl: $size can be 'foo / 2' so we need to add '(' and ')'
    
    'foo / 5 * sizeof(bar)' isn't the same as
    '(foo / 2) * sizeof(bar)'.
    
    metze

-----------------------------------------------------------------------

Summary of changes:
 source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm b/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
index 60d5bf8..ef3eb3d 100644
--- a/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
+++ b/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
@@ -2149,9 +2149,9 @@ sub ParseFunctionPull($$)
 			$self->pidl("NDR_PULL_ALLOC_N(ndr, r->out.$e->{NAME}, $size);");
 
 			if (grep(/in/, @{$e->{DIRECTION}})) {
-				$self->pidl("memcpy(r->out.$e->{NAME}, r->in.$e->{NAME}, $size * sizeof(*r->in.$e->{NAME}));");
+				$self->pidl("memcpy(r->out.$e->{NAME}, r->in.$e->{NAME}, ($size) * sizeof(*r->in.$e->{NAME}));");
 			} else {
-				$self->pidl("memset(r->out.$e->{NAME}, 0, $size * sizeof(*r->out.$e->{NAME}));");
+				$self->pidl("memset(r->out.$e->{NAME}, 0, ($size) * sizeof(*r->out.$e->{NAME}));");
 			}
 		} else {
 			$self->pidl("NDR_PULL_ALLOC(ndr, r->out.$e->{NAME});");


-- 
Samba Shared Repository


More information about the samba-cvs mailing list