[SCM] Samba Shared Repository - branch v3-0-test updated -
release-3-0-28-125-g3eb2d42
Jeremy Allison
jra at samba.org
Mon Feb 11 17:54:00 GMT 2008
The branch, v3-0-test has been updated
via 3eb2d427a9319199e862e6f6af5db32de6330b34 (commit)
from d0d9e485b505e7f75a844631a4c77316fc684ac0 (commit)
http://gitweb.samba.org/?samba.git;a=shortlog;h=v3-0-test
- Log -----------------------------------------------------------------
commit 3eb2d427a9319199e862e6f6af5db32de6330b34
Author: Jeremy Allison <jra at samba.org>
Date: Mon Feb 11 09:53:31 2008 -0800
Back-port from vl.
Author: Volker Lendecke <vl at samba.org>
Date: Mon Feb 11 18:36:06 2008 +0100
Add a missing return
If I'm not completely blind, we should return here. Not doing it here seems not
to be a major flaw, as far as I can see we're only missing the error code. This
might account for some of the very unhelpful NT_STATUS_UNSUCCESSFUL error
messages people see during joins.
All with stake in Samba client, please check!
-----------------------------------------------------------------------
Summary of changes:
source/libsmb/cliconnect.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/libsmb/cliconnect.c b/source/libsmb/cliconnect.c
index 2f6606f..42e0b63 100644
--- a/source/libsmb/cliconnect.c
+++ b/source/libsmb/cliconnect.c
@@ -630,7 +630,7 @@ static ADS_STATUS cli_session_setup_kerberos(struct cli_state *cli, const char *
if (!cli_session_setup_blob(cli, negTokenTarg, session_key_krb5)) {
data_blob_free(&negTokenTarg);
data_blob_free(&session_key_krb5);
- ADS_ERROR_NT(cli_nt_error(cli));
+ return ADS_ERROR_NT(cli_nt_error(cli));
}
cli_set_session_key(cli, session_key_krb5);
--
Samba Shared Repository
More information about the samba-cvs
mailing list