[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-test-2069-geadd15c

[Volker Lendecke]

The branch, v3-2-test has been updated
       via  eadd15c9363a57c214ede3c489057646baca48f8 (commit)
      from  9d6b43ea106df188b51060a8055fe5168220c314 (commit)

http://gitweb.samba.org/?samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit eadd15c9363a57c214ede3c489057646baca48f8
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Feb 11 18:36:06 2008 +0100

    Add a missing return
    
    If I'm not completely blind, we should return here. Not doing it here seems not
    to be a major flaw, as far as I can see we're only missing the error code. This
    might account for some of the very unhelpful NT_STATUS_UNSUCCESSFUL error
    messages people see during joins.
    
    All with stake in Samba client, please check!

-----------------------------------------------------------------------

Summary of changes:
 source/libsmb/cliconnect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/libsmb/cliconnect.c b/source/libsmb/cliconnect.c
index f3926b7..e97be98 100644
--- a/source/libsmb/cliconnect.c
+++ b/source/libsmb/cliconnect.c
@@ -627,7 +627,7 @@ static ADS_STATUS cli_session_setup_kerberos(struct cli_state *cli, const char *
 	if (!cli_session_setup_blob(cli, negTokenTarg, session_key_krb5)) {
 		data_blob_free(&negTokenTarg);
 		data_blob_free(&session_key_krb5);
-		ADS_ERROR_NT(cli_nt_error(cli));
+		return ADS_ERROR_NT(cli_nt_error(cli));
 	}
 
 	cli_set_session_key(cli, session_key_krb5);


-- 
Samba Shared Repository