[SCM] Samba Shared Repository - branch v3-devel updated - release-3-2-0pre2-3791-g1295bb9

Jeremy Allison jra at samba.org
Thu Aug 21 17:25:35 GMT 2008


The branch, v3-devel has been updated
       via  1295bb9787dde69b4be4acee7b66eb782afe9c42 (commit)
      from  f24cef9fa7be45212744d39b7c66804e64147afd (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-devel


- Log -----------------------------------------------------------------
commit 1295bb9787dde69b4be4acee7b66eb782afe9c42
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 21 10:25:02 2008 -0700

    Fix bug 5698 - mixup of TALLOC/malloc. Spotted by Douglas Wegscheid <Douglas_E_Wegscheid at whirlpool.com>.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source/lib/util_str.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/lib/util_str.c b/source/lib/util_str.c
index 5f26cc8..9f952ab 100644
--- a/source/lib/util_str.c
+++ b/source/lib/util_str.c
@@ -2008,6 +2008,7 @@ bool str_list_sub_basic( char **list, const char *smb_name,
 
 bool str_list_substitute(char **list, const char *pattern, const char *insert)
 {
+	TALLOC_CTX *ctx = list;
 	char *p, *s, *t;
 	ssize_t ls, lp, li, ld, i, d;
 
@@ -2030,7 +2031,7 @@ bool str_list_substitute(char **list, const char *pattern, const char *insert)
 			t = *list;
 			d = p -t;
 			if (ld) {
-				t = (char *) SMB_MALLOC(ls +ld +1);
+				t = TALLOC_ARRAY(ctx, char, ls +ld +1);
 				if (!t) {
 					DEBUG(0,("str_list_substitute: "
 						"Unable to allocate memory"));
@@ -2038,7 +2039,7 @@ bool str_list_substitute(char **list, const char *pattern, const char *insert)
 				}
 				memcpy(t, *list, d);
 				memcpy(t +d +li, p +lp, ls -d -lp +1);
-				SAFE_FREE(*list);
+				TALLOC_FREE(*list);
 				*list = t;
 				ls += ld;
 				s = t +d +li;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list