[SCM] Samba Shared Repository - branch v3-devel updated - release-3-2-0pre2-3750-g31ca7b2

[Jeremy Allison]

The branch, v3-devel has been updated
       via  31ca7b2dbbbfbb3a55670b58c08ebda68888af7e (commit)
      from  7849938906a9c859805cbaeca66fae9d3c515aad (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-devel


- Log -----------------------------------------------------------------
commit 31ca7b2dbbbfbb3a55670b58c08ebda68888af7e
Author: Volker Lendecke <vl at sernet.de>
Date:   Sat Aug 16 11:17:09 2008 +0200

    Attempt to fix Coverity ID 595
    
    is_ipaddress already dereferences "name", so the NULL check is pointless after
    calling it.

-----------------------------------------------------------------------

Summary of changes:
 source/libcli/nbt/nbtname.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/libcli/nbt/nbtname.c b/source/libcli/nbt/nbtname.c
index 2025ef7..fbb9550 100644
--- a/source/libcli/nbt/nbtname.c
+++ b/source/libcli/nbt/nbtname.c
@@ -420,7 +420,7 @@ _PUBLIC_ void nbt_choose_called_name(TALLOC_CTX *mem_ctx,
 	n->scope = NULL;
 	n->type = type;
 
-	if (is_ipaddress(name) || name == NULL) {
+	if ((name == NULL) || is_ipaddress(name)) {
 		n->name = "*SMBSERVER";
 		return;
 	}


-- 
Samba Shared Repository