[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3714-g60718a2

Jeremy Allison jra at samba.org
Wed Aug 13 23:54:19 GMT 2008


The branch, v3-3-test has been updated
       via  60718a203c1d90dbdcdcb2eaf6b37f6135fb411b (commit)
      from  f84bf454eef9e53b72c481ddd5d520d8c3e901d2 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit 60718a203c1d90dbdcdcb2eaf6b37f6135fb411b
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 13 16:52:53 2008 -0700

    Fix coverity CID: 594. Resource leak on error path.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source/rpc_server/srv_spoolss_nt.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/rpc_server/srv_spoolss_nt.c b/source/rpc_server/srv_spoolss_nt.c
index f802400..635898a 100644
--- a/source/rpc_server/srv_spoolss_nt.c
+++ b/source/rpc_server/srv_spoolss_nt.c
@@ -5037,8 +5037,10 @@ static WERROR getprinter_level_7(Printer_entry *print_hnd, int snum, RPC_BUFFER
 	if((printer=SMB_MALLOC_P(PRINTER_INFO_7))==NULL)
 		return WERR_NOMEM;
 
-	if (!construct_printer_info_7(print_hnd, printer, snum))
-		return WERR_NOMEM;
+	if (!construct_printer_info_7(print_hnd, printer, snum)) {
+		result = WERR_NOMEM;
+		goto out;
+	}
 
 	/* check the required size. */
 	*needed += spoolss_size_printer_info_7(printer);


-- 
Samba Shared Repository


More information about the samba-cvs mailing list