[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-2817-gdcd28df

Jeremy Allison jra at samba.org
Wed Aug 13 23:54:13 GMT 2008


The branch, v3-2-test has been updated
       via  dcd28df09538922369cb613ac95c147365e02c42 (commit)
      from  a46dc151f692e6b4bd14d3881f90bca5fe5b9474 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit dcd28df09538922369cb613ac95c147365e02c42
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 13 16:53:28 2008 -0700

    Fix coverity CID: 594. Resource leak on error path.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source/rpc_server/srv_spoolss_nt.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/rpc_server/srv_spoolss_nt.c b/source/rpc_server/srv_spoolss_nt.c
index cc7807d..92f68ea 100644
--- a/source/rpc_server/srv_spoolss_nt.c
+++ b/source/rpc_server/srv_spoolss_nt.c
@@ -5037,8 +5037,10 @@ static WERROR getprinter_level_7(Printer_entry *print_hnd, int snum, RPC_BUFFER
 	if((printer=SMB_MALLOC_P(PRINTER_INFO_7))==NULL)
 		return WERR_NOMEM;
 
-	if (!construct_printer_info_7(print_hnd, printer, snum))
-		return WERR_NOMEM;
+	if (!construct_printer_info_7(print_hnd, printer, snum)) {
+		result = WERR_NOMEM;
+		goto out;
+	}
 
 	/* check the required size. */
 	*needed += spoolss_size_printer_info_7(printer);


-- 
Samba Shared Repository


More information about the samba-cvs mailing list