[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-1061-g5df7557

[Volker Lendecke]

The branch, v3-2-test has been updated
       via  5df75578ef1da41164936cd11b14114889201d47 (commit)
      from  d2cb298a469b00cb5f8e15a3185a4a5d51e1b9ec (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 5df75578ef1da41164936cd11b14114889201d47
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Apr 22 15:41:25 2008 +0200

    Fix wbinfo --group-info if the winbind separator set to non \
    
    In getgrsid_lookupsid_recv() we use parse_domain_user which itself looks at
    lp_winbind_separator(). Thus when building up that group name we should better
    use it as well.

-----------------------------------------------------------------------

Summary of changes:
 WHATSNEW.txt                     |    1 +
 source/winbindd/winbindd_group.c |    6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index 001f0f8..364b3fe 100644
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
@@ -292,6 +292,7 @@ o   Volker Lendecke <vl at samba.org>
     * Make winbind use NetSamLogonEx when possible.
     * Merge fixes in the 3-0-ctdb cluster code.
     * Fix a segfault in snprintf replacement code.
+    * Fix a regression for wbinfo --group-info if winbind separator is set
 
 
 o   Derrell Lipman <derrell at samba.org>
diff --git a/source/winbindd/winbindd_group.c b/source/winbindd/winbindd_group.c
index d5d3acc..63fde9f 100644
--- a/source/winbindd/winbindd_group.c
+++ b/source/winbindd/winbindd_group.c
@@ -806,8 +806,10 @@ static void getgrsid_lookupsid_recv( void *private_data, bool success,
 }
 
 	if ( (s->group_name = talloc_asprintf( s->state->mem_ctx, 
-					       "%s\\%s", 
-					       dom_name, name )) == NULL )
+                                               "%s%c%s",
+                                               dom_name,
+					       *lp_winbind_separator(),
+                                               name)) == NULL )
 {
 		DEBUG(1, ("getgrsid_lookupsid_recv: talloc_asprintf() Failed!\n"));
 		request_error(s->state);


-- 
Samba Shared Repository