[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-815-gaacb07b

Volker Lendecke vlendec at samba.org
Fri Apr 11 20:39:13 GMT 2008


The branch, v3-2-test has been updated
       via  aacb07b1b0f674b8cb92347ef4b4dd1e7808dde8 (commit)
      from  05f7f77135ab997b92b2454871f21543ecbde0ed (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit aacb07b1b0f674b8cb92347ef4b4dd1e7808dde8
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Apr 11 22:20:32 2008 +0200

    Remove some write-only fstrings

-----------------------------------------------------------------------

Summary of changes:
 source/include/ntdomain.h    |    7 -------
 source/rpc_server/srv_pipe.c |   15 +++------------
 2 files changed, 3 insertions(+), 19 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/include/ntdomain.h b/source/include/ntdomain.h
index b89b0fe..74a5944 100644
--- a/source/include/ntdomain.h
+++ b/source/include/ntdomain.h
@@ -233,13 +233,6 @@ typedef struct pipes_struct {
 	struct dcinfo *dc; /* Keeps the creds data from netlogon. */
 
 	/*
-	 * Windows user info.
-	 */
-	fstring user_name;
-	fstring domain;
-	fstring wks;
-
-	/*
 	 * Unix user name and credentials used when a pipe is authenticated.
 	 */
 
diff --git a/source/rpc_server/srv_pipe.c b/source/rpc_server/srv_pipe.c
index 05cdb65..4ac9f7a 100644
--- a/source/rpc_server/srv_pipe.c
+++ b/source/rpc_server/srv_pipe.c
@@ -614,11 +614,6 @@ static bool pipe_ntlmssp_verify_final(pipes_struct *p, DATA_BLOB *p_resp_blob)
 
 	ZERO_STRUCT(reply);
 
-	memset(p->user_name, '\0', sizeof(p->user_name));
-	memset(p->pipe_user_name, '\0', sizeof(p->pipe_user_name));
-	memset(p->domain, '\0', sizeof(p->domain));
-	memset(p->wks, '\0', sizeof(p->wks));
-
 	/* Set up for non-authenticated user. */
 	TALLOC_FREE(p->pipe_user.nt_user_token);
 	p->pipe_user.ut.ngroups = 0;
@@ -656,14 +651,10 @@ static bool pipe_ntlmssp_verify_final(pipes_struct *p, DATA_BLOB *p_resp_blob)
 			return False;
 		}
 	}
-	
-	fstrcpy(p->user_name, a->ntlmssp_state->user);
-	fstrcpy(p->pipe_user_name, a->server_info->unix_name);
-	fstrcpy(p->domain, a->ntlmssp_state->domain);
-	fstrcpy(p->wks, a->ntlmssp_state->workstation);
 
-	DEBUG(5,("pipe_ntlmssp_verify_final: OK: user: %s domain: %s workstation: %s\n",
-		p->user_name, p->domain, p->wks));
+	DEBUG(5, ("pipe_ntlmssp_verify_final: OK: user: %s domain: %s "
+		  "workstation: %s\n", a->ntlmssp_state->user,
+		  a->ntlmssp_state->domain, a->ntlmssp_state->workstation));
 
 	/*
 	 * Store the UNIX credential data (uid/gid pair) in the pipe structure.


-- 
Samba Shared Repository


More information about the samba-cvs mailing list