[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-651-g0dc9840

[Michael Adam]

The branch, v3-2-test has been updated
       via  0dc9840cefb08b2732d294eb45508ce687ded324 (commit)
       via  26e3d71cd0b2d1bb31c50627ea71267328d52448 (commit)
      from  68d08ecf92be3444b759300237b2b7cf5238d022 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 0dc9840cefb08b2732d294eb45508ce687ded324
Author: Michael Adam <obnox at samba.org>
Date:   Fri Apr 4 17:52:35 2008 +0200

    net_rpc_registry: return available error code on failure in deletevalue.
    
    Michael

commit 26e3d71cd0b2d1bb31c50627ea71267328d52448
Author: Michael Adam <obnox at samba.org>
Date:   Fri Apr 4 17:50:41 2008 +0200

    net_rpc_registry: consistently return error upon wrong use.
    
    Michael

-----------------------------------------------------------------------

Summary of changes:
 source/utils/net_rpc_registry.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/utils/net_rpc_registry.c b/source/utils/net_rpc_registry.c
index 92aaf06..da078f4 100644
--- a/source/utils/net_rpc_registry.c
+++ b/source/utils/net_rpc_registry.c
@@ -473,7 +473,7 @@ static NTSTATUS rpc_registry_deletevalue_internal(const DOM_SID *domain_sid,
 	rpccli_winreg_CloseKey(pipe_hnd, mem_ctx, &key_hnd, NULL);
 	rpccli_winreg_CloseKey(pipe_hnd, mem_ctx, &hive_hnd, NULL);
 
-	return NT_STATUS_OK;
+	return status;
 }
 
 static int rpc_registry_deletevalue( int argc, const char **argv )
@@ -629,7 +629,7 @@ static NTSTATUS rpc_registry_enumerate_internal(const DOM_SID *domain_sid,
 	if (argc != 1 ) {
 		d_printf("Usage:    net rpc registry enumerate <path> [recurse]\n");
 		d_printf("Example:  net rpc registry enumerate 'HKLM\\Software\\Samba'\n");
-		return NT_STATUS_OK;
+		return NT_STATUS_INVALID_PARAMETER;
 	}
 
 	status = registry_openkey(mem_ctx, pipe_hnd, argv[0], REG_KEY_READ,
@@ -697,7 +697,7 @@ static NTSTATUS rpc_registry_save_internal(const DOM_SID *domain_sid,
 	
 	if (argc != 2 ) {
 		d_printf("Usage:    net rpc registry backup <path> <file> \n");
-		return NT_STATUS_OK;
+		return NT_STATUS_INVALID_PARAMETER;
 	}
 	
 	status = registry_openkey(mem_ctx, pipe_hnd, argv[0], REG_KEY_ALL,
@@ -882,7 +882,7 @@ static int rpc_registry_dump( int argc, const char **argv )
 	
 	if (argc != 1 ) {
 		d_printf("Usage:    net rpc registry dump <file> \n");
-		return 0;
+		return -1;
 	}
 	
 	d_printf("Opening %s....", argv[0]);
@@ -926,7 +926,7 @@ static int rpc_registry_copy( int argc, const char **argv )
 	
 	if (argc != 2 ) {
 		d_printf("Usage:    net rpc registry copy <srcfile> <newfile>\n");
-		return 0;
+		return -1;
 	}
 	
 	d_printf("Opening %s....", argv[0]);
@@ -997,7 +997,7 @@ static NTSTATUS rpc_registry_getsd_internal(const DOM_SID *domain_sid,
 	if (argc <1 || argc > 2) {
 		d_printf("Usage:    net rpc registry getsd <path> <secinfo>\n");
 		d_printf("Example:  net rpc registry getsd 'HKLM\\Software\\Samba'\n");
-		return NT_STATUS_OK;
+		return NT_STATUS_INVALID_PARAMETER;
 	}
 
 	status = registry_openkey(mem_ctx, pipe_hnd, argv[0],


-- 
Samba Shared Repository