[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-623-gc19fdf4

Jeremy Allison jra at samba.org
Wed Apr 2 18:24:08 GMT 2008


The branch, v3-2-test has been updated
       via  c19fdf43d16ce9fba3e8e12e6192bac31837715e (commit)
      from  b12edbeffee1f7d1fd971cde9189e5137ddeb35b (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit c19fdf43d16ce9fba3e8e12e6192bac31837715e
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Apr 2 11:23:36 2008 -0700

    Fix MSDFS bug noticed by Ofir Azoulay <Ofir.Azoulay at expand.com>.
    There is no reason to ensure the target host is ourselves, and
    this breaks MS clients in some cases.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source/smbd/msdfs.c |   30 ------------------------------
 1 files changed, 0 insertions(+), 30 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/smbd/msdfs.c b/source/smbd/msdfs.c
index 8ffa0f7..fb757a5 100644
--- a/source/smbd/msdfs.c
+++ b/source/smbd/msdfs.c
@@ -127,28 +127,6 @@ static NTSTATUS parse_dfs_path(const char *pathname,
 
 	DEBUG(10,("parse_dfs_path: hostname: %s\n",pdp->hostname));
 
-	/* If we got a hostname, is it ours (or an IP address) ? */
-	if (!is_myname_or_ipaddr(pdp->hostname)) {
-		/* Repair path. */
-		*p = sepchar;
-		DEBUG(10,("parse_dfs_path: hostname %s isn't ours. "
-			"Try local path from path %s\n",
-			pdp->hostname, temp));
-		/*
-		 * Possibly client sent a local path by mistake.
-		 * Try and convert to a local path.
-		 */
-
-		pdp->hostname = eos_ptr; /* "" */
-		pdp->servicename = eos_ptr; /* "" */
-
-		p = temp;
-		DEBUG(10,("parse_dfs_path: trying to convert %s "
-			"to a local path\n",
-			temp));
-		goto local_path;
-	}
-
 	/* Parse out servicename. */
 	temp = p+1;
 	p = strchr_m(temp,sepchar);
@@ -751,14 +729,6 @@ NTSTATUS get_referred_path(TALLOC_CTX *ctx,
 		return status;
 	}
 
-	/* Verify hostname in path */
-	if (!is_myname_or_ipaddr(pdp->hostname)) {
-		DEBUG(3, ("get_referred_path: Invalid hostname %s in path %s\n",
-			pdp->hostname, dfs_path));
-		TALLOC_FREE(pdp);
-		return NT_STATUS_NOT_FOUND;
-	}
-
 	jucn->service_name = talloc_strdup(ctx, pdp->servicename);
 	jucn->volume_name = talloc_strdup(ctx, pdp->reqpath);
 	if (!jucn->service_name || !jucn->volume_name) {


-- 
Samba Shared Repository


More information about the samba-cvs mailing list