[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-617-g547eacf

Stefan Metzmacher metze at samba.org
Tue Apr 1 16:50:14 GMT 2008


The branch, v3-2-test has been updated
       via  547eacf6058d2bc5b41b266b70f8f4747aca4eae (commit)
      from  ff87260f1268d190170608b0808c191ef8f3e942 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 547eacf6058d2bc5b41b266b70f8f4747aca4eae
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Apr 1 18:18:38 2008 +0200

    smbd: always close the base_fsp even if the real close returned an error
    
    Otherwise we may end up with share mode entry without an open file.
    
    Volker, Jeremy: please check...
    
    metze

-----------------------------------------------------------------------

Summary of changes:
 source/smbd/close.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/smbd/close.c b/source/smbd/close.c
index 4bd23a3..b06c0d1 100644
--- a/source/smbd/close.c
+++ b/source/smbd/close.c
@@ -665,10 +665,6 @@ NTSTATUS close_file(files_struct *fsp, enum file_close_type close_type)
 		status = close_normal_file(fsp, close_type);
 	}
 
-	if (!NT_STATUS_IS_OK(status)) {
-		return status;
-	}
-
 	if ((base_fsp != NULL) && (close_type != SHUTDOWN_CLOSE)) {
 
 		/*


-- 
Samba Shared Repository


More information about the samba-cvs mailing list