svn commit: samba r25166 - in branches/SAMBA_4_0: . source/pidl/lib/Parse/Pidl source/pidl/tests

[Jelmer Vernooij]

Hi Stefan,

Am Samstag, den 15.09.2007, 09:24 +0200 schrieb Stefan (metze)
Metzmacher:
> > +	foreach my $x (@{$type->{ELEMENTS}}) {
> > +		return 1 if ($x->{POINTERS});
> > +		return 1 if (can_contain_deferred ($x));
> doesn't this needs to be con_contain_deferred($x->{TYPE}),
> I'm not sure so please check this.
> 
> maybe we should have a more complex test which tested unions with
> structs in it where the struct contains a pointer.
I've added another simple test - I think all code paths in
can_contain_deferred() are tested now.

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org