svn commit: samba r25024 - in branches: SAMBA_3_0_25/source/groupdb SAMBA_3_2/source/groupdb SAMBA_3_2_0/source/groupdb

[vlendec at samba.org]

Author: vlendec
Date: 2007-09-08 09:15:08 +0000 (Sat, 08 Sep 2007)
New Revision: 25024

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25024

Log:
Fix a whole bunch of Coverity bugs

The callers of get_domain_group_from_sid() with some justification
expected map->gid to be initialized when get_domain_group_from_sid
returned True.

Modified:
   branches/SAMBA_3_0_25/source/groupdb/mapping.c
   branches/SAMBA_3_2/source/groupdb/mapping.c
   branches/SAMBA_3_2_0/source/groupdb/mapping.c


Changeset:
Modified: branches/SAMBA_3_0_25/source/groupdb/mapping.c
===================================================================
--- branches/SAMBA_3_0_25/source/groupdb/mapping.c	2007-09-08 05:35:10 UTC (rev 25023)
+++ branches/SAMBA_3_0_25/source/groupdb/mapping.c	2007-09-08 09:15:08 UTC (rev 25024)
@@ -179,6 +179,7 @@
 			fstrcpy( map->comment, "Ordinary Users" );
 			sid_copy( &map->sid, &sid );
 			map->sid_name_use = SID_NAME_DOM_GRP;
+			map->gid = (gid_t)-1;
 			
 			return True;
 		}

Modified: branches/SAMBA_3_2/source/groupdb/mapping.c
===================================================================
--- branches/SAMBA_3_2/source/groupdb/mapping.c	2007-09-08 05:35:10 UTC (rev 25023)
+++ branches/SAMBA_3_2/source/groupdb/mapping.c	2007-09-08 09:15:08 UTC (rev 25024)
@@ -145,6 +145,7 @@
 			fstrcpy( map->comment, "Ordinary Users" );
 			sid_copy( &map->sid, &sid );
 			map->sid_name_use = SID_NAME_DOM_GRP;
+			map->gid = (gid_t)-1;
 			
 			return True;
 		}

Modified: branches/SAMBA_3_2_0/source/groupdb/mapping.c
===================================================================
--- branches/SAMBA_3_2_0/source/groupdb/mapping.c	2007-09-08 05:35:10 UTC (rev 25023)
+++ branches/SAMBA_3_2_0/source/groupdb/mapping.c	2007-09-08 09:15:08 UTC (rev 25024)
@@ -145,6 +145,7 @@
 			fstrcpy( map->comment, "Ordinary Users" );
 			sid_copy( &map->sid, &sid );
 			map->sid_name_use = SID_NAME_DOM_GRP;
+			map->gid = (gid_t)-1;
 			
 			return True;
 		}