svn commit: samba r25689 - in branches/SAMBA_4_0/source/torture/raw: .

Stefan (metze) Metzmacher metze at samba.org
Thu Oct 18 07:00:24 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

tridge at samba.org schrieb:
> Author: tridge
> Date: 2007-10-18 01:37:46 +0000 (Thu, 18 Oct 2007)
> New Revision: 25689
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25689
> 
> Log:
> test with a non-zero size file

Hi Tridge,

wouldn't it be better to test with a zero file and with a non-zero one?
If there's a difference we should really test both.

metze

> 
> Changeset:
> Modified: branches/SAMBA_4_0/source/torture/raw/oplock.c
> ===================================================================
> --- branches/SAMBA_4_0/source/torture/raw/oplock.c	2007-10-17 18:26:40 UTC (rev 25688)
> +++ branches/SAMBA_4_0/source/torture/raw/oplock.c	2007-10-18 01:37:46 UTC (rev 25689)
> @@ -1462,6 +1462,7 @@
>  	for (i=0;i<ARRAY_SIZE(hold_info);i++) {
>  		union smb_open io;
>  		NTSTATUS status;
> +		char c = 1;
>  
>  		io.generic.level = RAW_OPEN_NTCREATEX;
>  		io.ntcreatex.in.root_fid = 0;
> @@ -1493,6 +1494,12 @@
>  			return false;
>  		}
>  		hold_info[i].fnum = io.ntcreatex.out.file.fnum;
> +
> +		/* make the file non-zero size */
> +		if (smbcli_write(cli->tree, hold_info[i].fnum, 0, &c, 0, 1) != 1) {
> +			printf("Failed to write to file\n");
> +			return false;
> +		}
>  	}
>  
>  	printf("Waiting for oplock events\n");
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHFwSIm70gjA5TCD8RAjMmAJ9eRrGxez0aStpBQczwkoqUg39+DQCfVebd
KHLCo+AjH5wg9ScAHe7T1r8=
=RU1u
-----END PGP SIGNATURE-----


More information about the samba-cvs mailing list