[SCM] Samba Shared Repository - branch v3-2-test updated

[Michael Adam]

The branch, v3-2-test has been updated
       via  e68671b59500d7e1b645c80ee264c49893f8df84 (commit)
      from  4dfda879a3ad44be7008702b9fbefe3858436118 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e68671b59500d7e1b645c80ee264c49893f8df84
Author: Michael Adam <obnox at samba.org>
Date:   Fri Oct 12 13:20:07 2007 +0200

    Add become_root/unbecome_root around one call of getsampwsid()
    in create_token_from_username(). This caused set_nt_acl to
    partially fail in certain circumstances.
    
    This is expected to bring an improvement to bug #4308.
    
    Michael

-----------------------------------------------------------------------

Summary of changes:
 source/auth/auth_util.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/auth/auth_util.c b/source/auth/auth_util.c
index 325b05f..2c05f04 100644
--- a/source/auth/auth_util.c
+++ b/source/auth/auth_util.c
@@ -721,6 +721,7 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx, const char *username,
 	}
 
 	if (sid_check_is_in_our_domain(&user_sid)) {
+		BOOL ret;
 
 		/* This is a passdb user, so ask passdb */
 
@@ -731,7 +732,11 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx, const char *username,
 			goto done;
 		}
 
-		if (!pdb_getsampwsid(sam_acct, &user_sid)) {
+		become_root();
+		ret = pdb_getsampwsid(sam_acct, &user_sid);
+		unbecome_root();
+
+		if (!ret) {
 			DEBUG(1, ("pdb_getsampwsid(%s) for user %s failed\n",
 				  sid_string_static(&user_sid), username));
 			DEBUGADD(1, ("Fall back to unix user %s\n", username));


-- 
Samba Shared Repository