svn commit: samba r25613 - in branches/SAMBA_4_0/source/lib/registry/tests: .

metze at samba.org metze at samba.org
Wed Oct 10 14:12:27 GMT 2007


Author: metze
Date: 2007-10-10 14:12:25 +0000 (Wed, 10 Oct 2007)
New Revision: 25613

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25613

Log:
verify the length and type before checking the value,
hopefully gives more info why this fails some bigendian
platforms

metze
Modified:
   branches/SAMBA_4_0/source/lib/registry/tests/hive.c


Changeset:
Modified: branches/SAMBA_4_0/source/lib/registry/tests/hive.c
===================================================================
--- branches/SAMBA_4_0/source/lib/registry/tests/hive.c	2007-10-10 13:56:47 UTC (rev 25612)
+++ branches/SAMBA_4_0/source/lib/registry/tests/hive.c	2007-10-10 14:12:25 UTC (rev 25613)
@@ -187,10 +187,9 @@
 	error = hive_get_value(mem_ctx, subkey, "Answer", &type, &value);
 	torture_assert_werr_ok(tctx, error, "getting value");
 
-	torture_assert(tctx, memcmp(value.data, &data, 4) == 0, "value data");
-
 	torture_assert_int_equal(tctx, value.length, 4, "value length");
 	torture_assert_int_equal(tctx, type, REG_DWORD, "value type");
+	torture_assert(tctx, memcmp(value.data, &data, 4) == 0, "value data");
 
 	return true;
 }
@@ -251,10 +250,10 @@
 	torture_assert_werr_ok(tctx, error, "getting value");
 
 	torture_assert_str_equal(tctx, name, "Answer", "value name");
-	torture_assert(tctx, memcmp(value.data, &data, 4) == 0, "value data");
 
 	torture_assert_int_equal(tctx, value.length, 4, "value length");
 	torture_assert_int_equal(tctx, type, REG_DWORD, "value type");
+	torture_assert(tctx, memcmp(value.data, &data, 4) == 0, "value data");
 
 	error = hive_get_value_by_index(mem_ctx, subkey, 1, &name,
 					&type, &value);



More information about the samba-cvs mailing list