svn commit: samba r25596 - in branches/SAMBA_4_0/source/torture/basic: .

abartlet at samba.org abartlet at samba.org
Wed Oct 10 01:54:10 GMT 2007


Author: abartlet
Date: 2007-10-10 01:54:07 +0000 (Wed, 10 Oct 2007)
New Revision: 25596

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25596

Log:
It isn't valid to take the address of an array on the stack, and this
isn't what memset wants anyway.

Thanks to Indar Kriplani <indar.kriplani at gmail.com>.  Fixes bug 5010

Andrew Bartlett

Modified:
   branches/SAMBA_4_0/source/torture/basic/base.c


Changeset:
Modified: branches/SAMBA_4_0/source/torture/basic/base.c
===================================================================
--- branches/SAMBA_4_0/source/torture/basic/base.c	2007-10-09 19:01:48 UTC (rev 25595)
+++ branches/SAMBA_4_0/source/torture/basic/base.c	2007-10-10 01:54:07 UTC (rev 25596)
@@ -415,7 +415,7 @@
 	cnum1 = cli->tree->tid;
 	vuid1 = cli->session->vuid;
 
-	memset(&buf, 0, 4); /* init buf so valgrind won't complain */
+	memset(buf, 0, 4); /* init buf so valgrind won't complain */
 	if (smbcli_write(cli->tree, fnum1, 0, buf, 130, 4) != 4) {
 		torture_comment(tctx, "initial write failed (%s)\n", smbcli_errstr(cli->tree));
 		return false;



More information about the samba-cvs mailing list