[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-391-g223352e

Jeremy Allison jra at samba.org
Wed Nov 28 17:46:08 GMT 2007


The branch, v3-2-test has been updated
       via  223352e32372f1b055298cfc6f2770043a845e3d (commit)
      from  3330394d2d5d58576d9ddb52f60a3e27f31d5198 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 223352e32372f1b055298cfc6f2770043a845e3d
Author: Volker Lendecke <vl at sernet.de>
Date:   Wed Nov 28 13:43:31 2007 +0100

    Add a warning for a potential bug I've run into

-----------------------------------------------------------------------

Summary of changes:
 source/lib/tdb/common/traverse.c |    3 +++
 source/lib/tdb/docs/README       |    3 +++
 2 files changed, 6 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/lib/tdb/common/traverse.c b/source/lib/tdb/common/traverse.c
index 6fc576a..27b2cfc 100644
--- a/source/lib/tdb/common/traverse.c
+++ b/source/lib/tdb/common/traverse.c
@@ -223,6 +223,9 @@ int tdb_traverse_read(struct tdb_context *tdb,
 /*
   a write style traverse - needs to get the transaction lock to
   prevent deadlocks
+
+  WARNING: The data buffer given to the callback fn does NOT meet the
+  alignment restrictions malloc gives you.
 */
 int tdb_traverse(struct tdb_context *tdb, 
 		 tdb_traverse_func fn, void *private_data)
diff --git a/source/lib/tdb/docs/README b/source/lib/tdb/docs/README
index b31ce36..63fcf5e 100644
--- a/source/lib/tdb/docs/README
+++ b/source/lib/tdb/docs/README
@@ -130,6 +130,9 @@ int tdb_traverse(TDB_CONTEXT *tdb, int (*fn)(TDB_CONTEXT *tdb,
    a non-zero return value from fn() indicates that the traversal
    should stop. Traversal callbacks may not start transactions.
 
+   WARNING: The data buffer given to the callback fn does NOT meet the
+   alignment restrictions malloc gives you.
+
 ----------------------------------------------------------------------
 int tdb_traverse_read(TDB_CONTEXT *tdb, int (*fn)(TDB_CONTEXT *tdb,
                      TDB_DATA key, TDB_DATA dbuf, void *state), void *state);


-- 
Samba Shared Repository


More information about the samba-cvs mailing list