Rev 671: explain why we don't use the usual -1/EACCES trick in http://samba.org/~tridge/3_0-ctdb

tridge at samba.org tridge at samba.org
Thu Nov 22 02:09:28 GMT 2007


------------------------------------------------------------
revno: 671
revision-id:tridge at samba.org-20071122020926-o2rz79uedmojans5
parent: tridge at samba.org-20071122015657-pkleqi180qha74eh
committer: Andrew Tridgell <tridge at samba.org>
branch nick: s3-ctdb-tridge
timestamp: Thu 2007-11-22 13:09:26 +1100
message:
  explain why we don't use the usual -1/EACCES trick
modified:
  source/modules/gpfs.c          gpfs.c-20070210173807-1wjifrbwaz6xnmgl-647
=== modified file 'source/modules/gpfs.c'
--- a/source/modules/gpfs.c	2007-11-22 01:56:57 +0000
+++ b/source/modules/gpfs.c	2007-11-22 02:09:26 +0000
@@ -106,6 +106,11 @@
 		gpfs_type = GPFS_LEASE_WRITE;
 	}
 
+	/* we unconditionally set CAP_LEASE, rather than looking for
+	   -1/EACCES as there is a bug in some versions of
+	   libgpfs_gpl.so which results in a leaked fd on /dev/ss0
+	   each time we try this with the wrong capabilities set
+	*/
 	linux_set_lease_capability();
 	return gpfs_set_lease_fn(fd, gpfs_type);
 }



More information about the samba-cvs mailing list