[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-235-g9a201fd

Stefan Metzmacher metze at samba.org
Thu Nov 8 12:53:42 GMT 2007


The branch, v3-2-test has been updated
       via  9a201fd4c81509eb8a93087a38bb0fda69dfd7e4 (commit)
      from  130de20d646fe14f494b021a98d6855c7b5b2a1a (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 9a201fd4c81509eb8a93087a38bb0fda69dfd7e4
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Nov 8 13:52:56 2007 +0100

    we should not ignore convert_string_talloc() failures.
    
    In all other places in ndr_string.c we already use False...
    
    metze

-----------------------------------------------------------------------

Summary of changes:
 source/librpc/ndr/ndr_string.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/librpc/ndr/ndr_string.c b/source/librpc/ndr/ndr_string.c
index bc4582c..8c0b723 100644
--- a/source/librpc/ndr/ndr_string.c
+++ b/source/librpc/ndr/ndr_string.c
@@ -84,7 +84,7 @@ NTSTATUS ndr_pull_string(struct ndr_pull *ndr, int ndr_flags, const char **s)
 						    chset, CH_UNIX, 
 						    ndr->data+ndr->offset, 
 						    (len2 + c_len_term)*byte_mul,
-						    &as, True);
+						    &as, False);
 			if (ret == -1) {
 				return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
 						      "Bad character conversion");


-- 
Samba Shared Repository


More information about the samba-cvs mailing list