svn commit: samba r25829 - in branches/SAMBA_4_0/source/librpc/rpc: .

[metze at samba.org]

Author: metze
Date: 2007-11-05 07:09:41 +0000 (Mon, 05 Nov 2007)
New Revision: 25829

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25829

Log:
- use DEBUG() instead of printf
- return an error if strings doesn't match on validate

metze
Modified:
   branches/SAMBA_4_0/source/librpc/rpc/dcerpc.c


Changeset:
Modified: branches/SAMBA_4_0/source/librpc/rpc/dcerpc.c
===================================================================
--- branches/SAMBA_4_0/source/librpc/rpc/dcerpc.c	2007-11-05 06:58:57 UTC (rev 25828)
+++ branches/SAMBA_4_0/source/librpc/rpc/dcerpc.c	2007-11-05 07:09:41 UTC (rev 25829)
@@ -1291,7 +1291,7 @@
 				       NDR_OUT, st);
 	if (strcmp(s1, s2) != 0) {
 #if 1
-		printf("VALIDATE ERROR:\nWIRE:\n%s\n GEN:\n%s\n", s1, s2);
+		DEBUG(3,("VALIDATE ERROR:\nWIRE:\n%s\n GEN:\n%s\n", s1, s2));
 #else
 		/* this is sometimes useful */
 		printf("VALIDATE ERROR\n");
@@ -1299,6 +1299,8 @@
 		file_save("gen.dat", s2, strlen(s2));
 		system("diff -u wire.dat gen.dat");
 #endif
+		return ndr_push_error(push, NDR_ERR_VALIDATE,
+				      "failed output validation strings doesn't match");
 	}
 
 	return NT_STATUS_OK;