svn commit: samba r25779 - in branches/SAMBA_4_0/source/librpc/ndr: .

metze at samba.org metze at samba.org
Thu Nov 1 10:15:13 GMT 2007


Author: metze
Date: 2007-11-01 10:15:13 +0000 (Thu, 01 Nov 2007)
New Revision: 25779

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25779

Log:
the return value of ndr_pull_set_switch_value() should be checked

metze
Modified:
   branches/SAMBA_4_0/source/librpc/ndr/ndr.c


Changeset:
Modified: branches/SAMBA_4_0/source/librpc/ndr/ndr.c
===================================================================
--- branches/SAMBA_4_0/source/librpc/ndr/ndr.c	2007-11-01 10:13:36 UTC (rev 25778)
+++ branches/SAMBA_4_0/source/librpc/ndr/ndr.c	2007-11-01 10:15:13 UTC (rev 25779)
@@ -760,7 +760,7 @@
 	struct ndr_pull *ndr;
 	ndr = ndr_pull_init_blob(blob, mem_ctx);
 	NT_STATUS_HAVE_NO_MEMORY(ndr);
-	ndr_pull_set_switch_value(ndr, p, level);
+	NDR_CHECK(ndr_pull_set_switch_value(ndr, p, level));
 	NDR_CHECK(fn(ndr, NDR_SCALARS|NDR_BUFFERS, p));
 	return NT_STATUS_OK;
 }
@@ -775,7 +775,7 @@
 	struct ndr_pull *ndr;
 	ndr = ndr_pull_init_blob(blob, mem_ctx);
 	NT_STATUS_HAVE_NO_MEMORY(ndr);
-	ndr_pull_set_switch_value(ndr, p, level);
+	NDR_CHECK(ndr_pull_set_switch_value(ndr, p, level));
 	NDR_CHECK(fn(ndr, NDR_SCALARS|NDR_BUFFERS, p));
 	if (ndr->offset < ndr->data_size) {
 		return ndr_pull_error(ndr, NDR_ERR_UNREAD_BYTES,



More information about the samba-cvs mailing list