svn commit: samba r23284 - in branches/SAMBA_3_0/source/nsswitch: .

obnox at samba.org obnox at samba.org
Thu May 31 23:58:57 GMT 2007


Author: obnox
Date: 2007-05-31 23:58:56 +0000 (Thu, 31 May 2007)
New Revision: 23284

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23284

Log:
Oh what a nasty typo! This gave me some headache,
with talloc randomly failing.

Hey, shouldn't TALLOC_ARRAY _not_ return NULL when
requested to allocate an array with zero entries? :-)

Michael


Modified:
   branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c


Changeset:
Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c
===================================================================
--- branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c	2007-05-31 23:55:37 UTC (rev 23283)
+++ branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c	2007-05-31 23:58:56 UTC (rev 23284)
@@ -975,7 +975,7 @@
 	 * we try to resolve as many sids as possible from the
 	 * cache. Only the rest is passed to the lsa_lookup_sids call. */
 	
-	if (num_names) {
+	if (num_members) {
 		(*sid_mem) = TALLOC_ZERO_ARRAY(mem_ctx, DOM_SID, num_members);
 		(*names) = TALLOC_ZERO_ARRAY(mem_ctx, char *, num_members);
 		(*name_types) = TALLOC_ZERO_ARRAY(mem_ctx, uint32, num_members);



More information about the samba-cvs mailing list