svn commit: samba r23257 - in branches/SAMBA_4_0/source/selftest: .

abartlet at samba.org abartlet at samba.org
Thu May 31 00:00:22 GMT 2007


Author: abartlet
Date: 2007-05-31 00:00:19 +0000 (Thu, 31 May 2007)
New Revision: 23257

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23257

Log:
Newer OpenLDAP versions don't seem to need this, so simplfy.  

Andrew Bartlett

Modified:
   branches/SAMBA_4_0/source/selftest/Samba4.pm


Changeset:
Modified: branches/SAMBA_4_0/source/selftest/Samba4.pm
===================================================================
--- branches/SAMBA_4_0/source/selftest/Samba4.pm	2007-05-30 23:06:48 UTC (rev 23256)
+++ branches/SAMBA_4_0/source/selftest/Samba4.pm	2007-05-31 00:00:19 UTC (rev 23257)
@@ -204,9 +204,9 @@
 	return ($fedora_ds_dir, $pidfile);
 }
 
-sub mk_openldap($$$$$)
+sub mk_openldap($$$)
 {
-	my ($self, $ldapdir, $configuration, $basedn, $dnsname, $password) = @_;
+	my ($self, $ldapdir, $configuration) = @_;
 
 	my $slapd_conf = "$ldapdir/slapd.conf";
 	my $pidfile = "$ldapdir/slapd.pid";
@@ -233,8 +233,6 @@
 	}
 
 	system("slaptest -u -f $slapd_conf") == 0 or die("slaptest still fails after adding modules");
-	system("slapadd -b cn=Configuration,$basedn -f $slapd_conf -l $ldapdir/$dnsname-config.ldif >/dev/null") == 0 or die("slapadd failed");
-	system("slapadd -b cn=Schema,cn=Configuration,$basedn -f $slapd_conf -l $ldapdir/$dnsname-schema.ldif >/dev/null") == 0 or die("slapadd failed");
 
     
 	$ENV{PATH} = $oldpath;
@@ -438,7 +436,7 @@
 	        system("$self->{bindir}/smbscript $self->{setupdir}/provision-backend $configuration --ldap-manager-pass=$password --root=$root --realm=$dnsname --host-name=$netbiosname --ldap-backend-type=$self->{ldap}>&2") == 0 or die("backend provision failed");
 
 	        if ($self->{ldap} eq "openldap") {
-		       ($ret->{SLAPD_CONF}, $ret->{OPENLDAP_PIDFILE}) = $self->mk_openldap($ldapdir, $configuration, $basedn, $dnsname, $password) or die("Unable to create openldap directories");
+		       ($ret->{SLAPD_CONF}, $ret->{OPENLDAP_PIDFILE}) = $self->mk_openldap($ldapdir, $configuration) or die("Unable to create openldap directories");
 	        } elsif ($self->{ldap} eq "fedora-ds") {
 		       ($ret->{FEDORA_DS_DIR}, $ret->{FEDORA_DS_PIDFILE}) = $self->mk_fedora_ds($ldapdir, $configuration) or die("Unable to create fedora ds directories");
 		       push (@provision_options, "--ldap-module=nsuniqueid");



More information about the samba-cvs mailing list