svn commit: samba r23108 - in branches: SAMBA_3_0/source/lib/replace SAMBA_3_0_26/source/lib/replace SAMBA_4_0/source/lib/replace

derrell.lipman at unwireduniverse.com derrell.lipman at unwireduniverse.com
Thu May 24 12:27:51 GMT 2007


"Stefan (metze) Metzmacher" <metze at samba.org> writes:

> seems that revision 22772 wasn't merged into all branches...
> http://websvn.samba.org/cgi-bin/viewcvs.cgi?rev=22772&view=rev

Sorry, I think I merged it to all of the Samba3 branches, but it didn't
occur to me that the same code was used in Samba4.

> maybe we should better move this to samba3 instead of libreplace...
> as libreplace will not provide replacements for readahead().

That change should be merged into libreplace in Samba4.  The problem it
was intended to solve -- an existing readahead() function but no header
that declares it -- would exist just as much in Samba4 as in Samba3
(even if nothing in Samba4 currently uses readahead).  Please go ahead
and merge that in with the current work.  (There's also a configure test
that was added in the same patch.)

Derrell


More information about the samba-cvs mailing list