svn commit: samba r22731 - in branches/SAMBA_3_0/source: . tests

[derrell at samba.org]

Author: derrell
Date: 2007-05-07 03:02:24 +0000 (Mon, 07 May 2007)
New Revision: 22731

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22731

Log:

- Fix bug #4594.
  
  configure.in determines if -Werror-implicit-function-declaration is
  available, and if so it enables that flag if --enable-developer is
  specified.  Since the configure tests themselves did not use that flag, it
  was possible for a configure test to succeed, followed by a failed
  compilation due to a facility being available but not having a proper
  declaration in a header file.  (This bit me with readahead().)  This patch
  ensures that if implicit function declarations will kill the build, the
  feature being tested is deselected so the build will succeed.

  The autoconf manual suggests using return instead of exit in configure
  tests because the declaration for exit is often missing.  We require this
  now, since we error if prototypes are missing.  See section 5.5.1 of
  http://www.gnu.org/software/autoconf/manual/autoconf.html.  This patch makes
  these changes, because in fact, an external declaration for exit is missing
  here (and likely elsewhere).

  I've verified that the features selected (here) with the original
  configure.in and the new one are the same except for, in my case,
  readahead.  I've also confirmed that the generated Makefile is identical.

  These changes are not being applied to the 3.0.26 branch because it does not
  exhibit the initial problem this patch is supposed to solve since it doesn't
  attempt to use -Werror-implicit-function-declaration.

Modified:
   branches/SAMBA_3_0/source/configure.in
   branches/SAMBA_3_0/source/tests/crypttest.c
   branches/SAMBA_3_0/source/tests/fcntl_lock.c
   branches/SAMBA_3_0/source/tests/fcntl_lock64.c
   branches/SAMBA_3_0/source/tests/ftruncate.c
   branches/SAMBA_3_0/source/tests/getgroups.c
   branches/SAMBA_3_0/source/tests/shared_mmap.c
   branches/SAMBA_3_0/source/tests/summary.c
   branches/SAMBA_3_0/source/tests/trivial.c
   branches/SAMBA_3_0/source/tests/unixsock.c


Changeset:
Sorry, the patch is too large (858 lines) to include; please use WebSVN to see it!
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22731