svn commit: samba r22015 - in branches: SAMBA_3_0/source/nsswitch SAMBA_3_0_25/source/nsswitch

jra at samba.org jra at samba.org
Fri Mar 30 22:35:42 GMT 2007


Author: jra
Date: 2007-03-30 22:35:35 +0000 (Fri, 30 Mar 2007)
New Revision: 22015

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22015

Log:
Fix for memory leak from Steven Danneman <steven.danneman at isilon.com>
Jeremy.

Modified:
   branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c
   branches/SAMBA_3_0_25/source/nsswitch/winbindd_ads.c


Changeset:
Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c
===================================================================
--- branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c	2007-03-30 22:25:08 UTC (rev 22014)
+++ branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c	2007-03-30 22:35:35 UTC (rev 22015)
@@ -931,6 +931,8 @@
 			if (num_retries < 5) {
 				num_retries++;
 				num_members = 0;
+				ads_msgfree(ads, res);
+				res = NULL;
 				continue;
 			} else {
 				DEBUG(5, ("ads: lookup_groupmem USN on this record changed"
@@ -947,6 +949,9 @@
 						 &num_members,
 						 &more_values);
 
+		ads_msgfree(ads, res);
+		res = NULL;
+
 		if ((members == NULL) || (num_members == 0))
 			break;
 

Modified: branches/SAMBA_3_0_25/source/nsswitch/winbindd_ads.c
===================================================================
--- branches/SAMBA_3_0_25/source/nsswitch/winbindd_ads.c	2007-03-30 22:25:08 UTC (rev 22014)
+++ branches/SAMBA_3_0_25/source/nsswitch/winbindd_ads.c	2007-03-30 22:35:35 UTC (rev 22015)
@@ -931,6 +931,8 @@
 			if (num_retries < 5) {
 				num_retries++;
 				num_members = 0;
+				ads_msgfree(ads, res);
+				res = NULL;
 				continue;
 			} else {
 				DEBUG(5, ("ads: lookup_groupmem USN on this record changed"
@@ -947,6 +949,9 @@
 						 &num_members,
 						 &more_values);
 
+		ads_msgfree(ads, res);
+		res = NULL;
+
 		if ((members == NULL) || (num_members == 0))
 			break;
 



More information about the samba-cvs mailing list