svn commit: samba r21937 - in branches/SAMBA_3_0_25/source/libsmb: .

[derrell at samba.org]

Jeremy Allison <jra at samba.org> writes:

> On Thu, Mar 22, 2007 at 03:48:16PM -0400, derrell at samba.org wrote:
>> 
>> No, it was no accident that these were not included in 3.0.25.  Those are the
>> intended fixes for bugs 4115 and 4309, both of which I have no way to test and
>> was awaiting confirmation from the OP of each bug that they are fixed (and
>> don't break anything else).  I have received no confirmation.
>> 
>> I'm perfectly happy for you to review those two bug reports and my fixes and
>> "bless" them into 3.0.25; I just wasn't sufficiently comfortable adding code
>> into an about-to-be released branch without any ability to test the fixes.
>
> Trouble is Derrell that there's often no way to
> get confirmation without having code out there
> in a binary for for people to test.

I had requested confirmation from the OP, but got no response.

> I'm comfortable with these changes and have
> the test environment for them but you have to
> realize no one tests 3.0 - it's essentially
> experimental (as my recent build farm breakage
> proved). Code there will *not* get tested by
> the quite good QA process we have for the
> "closer to release" branch.

If you're comfortable, I'm comfortable. :-)

I have high standards for myself...  I don't like to release buggy code, and
prefer that the code go nowhere than go somewhere and come back to haunt me.
I would think that if people report bugs, they'd at least get back to me with
whether the fix worked when I work on it for them.  No such luck. :-( Sigh.

Fine.  Ship it! :-)

Cheers,

Derrell