svn commit: samba r21814 - in branches: SAMBA_3_0/source/librpc/ndr SAMBA_4_0/source/librpc/ndr

tridge at samba.org tridge at samba.org
Tue Mar 13 04:42:50 GMT 2007


Author: tridge
Date: 2007-03-13 04:42:49 +0000 (Tue, 13 Mar 2007)
New Revision: 21814

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=21814

Log:
use ndr_push_error in the ndr layer, not just a NTSTATUS failure
Modified:
   branches/SAMBA_3_0/source/librpc/ndr/ndr.c
   branches/SAMBA_4_0/source/librpc/ndr/ndr.c


Changeset:
Modified: branches/SAMBA_3_0/source/librpc/ndr/ndr.c
===================================================================
--- branches/SAMBA_3_0/source/librpc/ndr/ndr.c	2007-03-13 04:37:09 UTC (rev 21813)
+++ branches/SAMBA_3_0/source/librpc/ndr/ndr.c	2007-03-13 04:42:49 UTC (rev 21814)
@@ -168,7 +168,8 @@
 
 	if (size < ndr->offset) {
 		/* extra_size overflowed the offset */
-		return NT_STATUS_NO_MEMORY;
+		return ndr_push_error(ndr, NDR_ERR_BUFSIZE, "Overflow in push_expand to %u",
+				      size);
 	}
 
 	if (ndr->alloc_size > size) {

Modified: branches/SAMBA_4_0/source/librpc/ndr/ndr.c
===================================================================
--- branches/SAMBA_4_0/source/librpc/ndr/ndr.c	2007-03-13 04:37:09 UTC (rev 21813)
+++ branches/SAMBA_4_0/source/librpc/ndr/ndr.c	2007-03-13 04:42:49 UTC (rev 21814)
@@ -156,7 +156,8 @@
 
 	if (size < ndr->offset) {
 		/* extra_size overflowed the offset */
-		return NT_STATUS_NO_MEMORY;
+		return ndr_push_error(ndr, NDR_ERR_BUFSIZE, "Overflow in push_expand to %u",
+				      size);
 	}
 
 	if (ndr->alloc_size > size) {



More information about the samba-cvs mailing list