svn commit: samba r21626 - in branches: SAMBA_3_0/source/nsswitch SAMBA_3_0_25/source/nsswitch

jerry at samba.org jerry at samba.org
Thu Mar 1 05:52:38 GMT 2007


Author: jerry
Date: 2007-03-01 05:52:38 +0000 (Thu, 01 Mar 2007)
New Revision: 21626

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=21626

Log:
Fix memory leak on error path noticed by 
SATOH Fumiyasu <fumiya at samba.gr.jp>

Modified:
   branches/SAMBA_3_0/source/nsswitch/winbindd_cred_cache.c
   branches/SAMBA_3_0_25/source/nsswitch/winbindd_cred_cache.c


Changeset:
Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_cred_cache.c
===================================================================
--- branches/SAMBA_3_0/source/nsswitch/winbindd_cred_cache.c	2007-03-01 05:45:45 UTC (rev 21625)
+++ branches/SAMBA_3_0/source/nsswitch/winbindd_cred_cache.c	2007-03-01 05:52:38 UTC (rev 21626)
@@ -517,6 +517,7 @@
 	if ((mlock(memcredp->nt_hash, memcredp->len)) == -1) {
 		DEBUG(0,("failed to mlock memory: %s (%d)\n", 
 			strerror(errno), errno));
+		SAFE_FREE(memcredp->nt_hash);
 		return map_nt_error_from_unix(errno);
 	}
 

Modified: branches/SAMBA_3_0_25/source/nsswitch/winbindd_cred_cache.c
===================================================================
--- branches/SAMBA_3_0_25/source/nsswitch/winbindd_cred_cache.c	2007-03-01 05:45:45 UTC (rev 21625)
+++ branches/SAMBA_3_0_25/source/nsswitch/winbindd_cred_cache.c	2007-03-01 05:52:38 UTC (rev 21626)
@@ -517,6 +517,7 @@
 	if ((mlock(memcredp->nt_hash, memcredp->len)) == -1) {
 		DEBUG(0,("failed to mlock memory: %s (%d)\n", 
 			strerror(errno), errno));
+		SAFE_FREE(memcredp->nt_hash);
 		return map_nt_error_from_unix(errno);
 	}
 



More information about the samba-cvs mailing list