svn commit: samba r23633 - in branches/SAMBA_3_0/source/rpc_server: .

jerry at samba.org jerry at samba.org
Wed Jun 27 16:52:36 GMT 2007


Author: jerry
Date: 2007-06-27 16:52:36 +0000 (Wed, 27 Jun 2007)
New Revision: 23633

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23633

Log:
Fix a couple of crash bugs pointed out by Volker caused by an old
change from a pstring to a char* and still trying use pstrcpy().

Modified:
   branches/SAMBA_3_0/source/rpc_server/srv_winreg_nt.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_server/srv_winreg_nt.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_server/srv_winreg_nt.c	2007-06-27 16:52:34 UTC (rev 23632)
+++ branches/SAMBA_3_0/source/rpc_server/srv_winreg_nt.c	2007-06-27 16:52:36 UTC (rev 23633)
@@ -661,7 +661,12 @@
 			topkeypath ));
 		return WERR_BADFILE;
 	}
-	pstrcpy( registry_key.name, topkeypath );
+
+	registry_key.name = talloc_strdup( regfile->mem_ctx, topkeypath );
+	if ( !registry_key.name ) {
+		DEBUG(0,("reg_load_tree: Talloc failed for reg_key.name!\n"));
+		return WERR_NOMEM;
+	}
 	
 	/* now start parsing the values and subkeys */
 



More information about the samba-cvs mailing list