svn commit: samba r23488 - in branches/SAMBA_4_0/source/kdc: .

metze at samba.org metze at samba.org
Thu Jun 14 12:19:54 GMT 2007


Author: metze
Date: 2007-06-14 12:19:53 +0000 (Thu, 14 Jun 2007)
New Revision: 23488

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23488

Log:
hdb_openp has changed from void * to int...

lha: what is the reason for this? it's really bad to use
     an int for storing a pointer value...

metze
Modified:
   branches/SAMBA_4_0/source/kdc/hdb-ldb.c


Changeset:
Modified: branches/SAMBA_4_0/source/kdc/hdb-ldb.c
===================================================================
--- branches/SAMBA_4_0/source/kdc/hdb-ldb.c	2007-06-14 12:05:08 UTC (rev 23487)
+++ branches/SAMBA_4_0/source/kdc/hdb-ldb.c	2007-06-14 12:19:53 UTC (rev 23488)
@@ -1015,7 +1015,7 @@
 
 	if (ret != 0) {
 		talloc_free(priv);
-		db->hdb_openp = NULL;
+		db->hdb_openp = 0;
 	} else {
 		talloc_free(mem_ctx);
 	}
@@ -1094,13 +1094,14 @@
 	priv->msgs = talloc_steal(priv, res->msgs);
 	talloc_free(res);
 
-	db->hdb_openp = priv;
+	/* why has hdb_openp changed from (void *) to (int) ??? */
+	db->hdb_openp = (int)priv;
 
 	ret = LDB_seq(context, db, flags, entry);
-	
+
 	if (ret != 0) {
     		talloc_free(priv);
-		db->hdb_openp = NULL;
+		db->hdb_openp = 0;
 	} else {
 		talloc_free(mem_ctx);
 	}



More information about the samba-cvs mailing list