svn commit: samba r23356 - in branches: SAMBA_3_0/source/lib SAMBA_3_0_25/source/lib SAMBA_3_0_26/source/lib

idra at samba.org idra at samba.org
Tue Jun 5 12:58:20 GMT 2007


Author: idra
Date: 2007-06-05 12:58:18 +0000 (Tue, 05 Jun 2007)
New Revision: 23356

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23356

Log:

We missed to add the 'c' character to the list of valid ones for
shell escaping.

I hate this kind of bugs more than how Jeremy hates off by ones :(

Simo.


Modified:
   branches/SAMBA_3_0/source/lib/util_str.c
   branches/SAMBA_3_0_25/source/lib/util_str.c
   branches/SAMBA_3_0_26/source/lib/util_str.c


Changeset:
Modified: branches/SAMBA_3_0/source/lib/util_str.c
===================================================================
--- branches/SAMBA_3_0/source/lib/util_str.c	2007-06-05 10:49:05 UTC (rev 23355)
+++ branches/SAMBA_3_0/source/lib/util_str.c	2007-06-05 12:58:18 UTC (rev 23356)
@@ -2622,7 +2622,7 @@
  of characters. UNIX charset format.
 *******************************************************************/
 
-#define INCLUDE_LIST "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabdefghijklmnopqrstuvwxyz_/ \t.,"
+#define INCLUDE_LIST "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_/ \t.,"
 #define INSIDE_DQUOTE_LIST "$`\n\"\\"
 
 char *escape_shell_string(const char *src)

Modified: branches/SAMBA_3_0_25/source/lib/util_str.c
===================================================================
--- branches/SAMBA_3_0_25/source/lib/util_str.c	2007-06-05 10:49:05 UTC (rev 23355)
+++ branches/SAMBA_3_0_25/source/lib/util_str.c	2007-06-05 12:58:18 UTC (rev 23356)
@@ -2622,7 +2622,7 @@
  of characters. UNIX charset format.
 *******************************************************************/
 
-#define INCLUDE_LIST "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabdefghijklmnopqrstuvwxyz_/ \t.,"
+#define INCLUDE_LIST "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_/ \t.,"
 #define INSIDE_DQUOTE_LIST "$`\n\"\\"
 
 char *escape_shell_string(const char *src)

Modified: branches/SAMBA_3_0_26/source/lib/util_str.c
===================================================================
--- branches/SAMBA_3_0_26/source/lib/util_str.c	2007-06-05 10:49:05 UTC (rev 23355)
+++ branches/SAMBA_3_0_26/source/lib/util_str.c	2007-06-05 12:58:18 UTC (rev 23356)
@@ -2622,7 +2622,7 @@
  of characters. UNIX charset format.
 *******************************************************************/
 
-#define INCLUDE_LIST "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabdefghijklmnopqrstuvwxyz_/ \t.,"
+#define INCLUDE_LIST "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_/ \t.,"
 #define INSIDE_DQUOTE_LIST "$`\n\"\\"
 
 char *escape_shell_string(const char *src)



More information about the samba-cvs mailing list