svn commit: samba r23342 - in branches: SAMBA_3_0/source/rpc_parse SAMBA_3_0_25/source/rpc_parse SAMBA_3_0_26/source/rpc_parse

jra at samba.org jra at samba.org
Mon Jun 4 19:29:41 GMT 2007


Author: jra
Date: 2007-06-04 19:29:40 +0000 (Mon, 04 Jun 2007)
New Revision: 23342

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23342

Log:
Stop Coverity from getting confused.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/rpc_parse/parse_prs.c
   branches/SAMBA_3_0_25/source/rpc_parse/parse_prs.c
   branches/SAMBA_3_0_26/source/rpc_parse/parse_prs.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_parse/parse_prs.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_parse/parse_prs.c	2007-06-04 19:03:33 UTC (rev 23341)
+++ branches/SAMBA_3_0/source/rpc_parse/parse_prs.c	2007-06-04 19:29:40 UTC (rev 23342)
@@ -1094,6 +1094,9 @@
 				return False;
 		} else {
 			str->buffer = NULL;
+			/* Return early to ensure Coverity isn't confused. */
+			DEBUG(5,("%s%04x %s: \n", tab_depth(depth), ps->data_offset, name));
+			return True;
 		}
 	}
 

Modified: branches/SAMBA_3_0_25/source/rpc_parse/parse_prs.c
===================================================================
--- branches/SAMBA_3_0_25/source/rpc_parse/parse_prs.c	2007-06-04 19:03:33 UTC (rev 23341)
+++ branches/SAMBA_3_0_25/source/rpc_parse/parse_prs.c	2007-06-04 19:29:40 UTC (rev 23342)
@@ -1094,6 +1094,9 @@
 				return False;
 		} else {
 			str->buffer = NULL;
+			/* Return early to ensure Coverity isn't confused. */
+			DEBUG(5,("%s%04x %s: \n", tab_depth(depth), ps->data_offset, name));
+			return True;
 		}
 	}
 

Modified: branches/SAMBA_3_0_26/source/rpc_parse/parse_prs.c
===================================================================
--- branches/SAMBA_3_0_26/source/rpc_parse/parse_prs.c	2007-06-04 19:03:33 UTC (rev 23341)
+++ branches/SAMBA_3_0_26/source/rpc_parse/parse_prs.c	2007-06-04 19:29:40 UTC (rev 23342)
@@ -1094,6 +1094,9 @@
 				return False;
 		} else {
 			str->buffer = NULL;
+			/* Return early to ensure Coverity isn't confused. */
+			DEBUG(5,("%s%04x %s: \n", tab_depth(depth), ps->data_offset, name));
+			return True;
 		}
 	}
 



More information about the samba-cvs mailing list