svn commit: samba r23290 - in branches: SAMBA_3_0/source/nsswitch SAMBA_3_0_26/source/nsswitch

[Jeremy Allison]

On Fri, Jun 01, 2007 at 12:18:17PM +0000, obnox at samba.org wrote:
> Author: obnox
> Date: 2007-06-01 12:18:16 +0000 (Fri, 01 Jun 2007)
> New Revision: 23290
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23290
> 
> Log:
> Fix another small and stupid but severe typo. 
> Hopfully, I have finally got this right... :-)
> 
> Michael
> 
> 
> Modified:
>    branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c
>    branches/SAMBA_3_0_26/source/nsswitch/winbindd_ads.c
> 
> 
> Changeset:
> Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c
> ===================================================================
> --- branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c	2007-06-01 12:01:53 UTC (rev 23289)
> +++ branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c	2007-06-01 12:18:16 UTC (rev 23290)
> @@ -1054,7 +1054,7 @@
>  				{
>  					sid_copy(&(*sid_mem)[*num_names],
>  						 &sid_mem_nocache[i]);
> -					(*names)[*num_names] = talloc_move(names, &names_nocache[i]);
> +					(*names)[*num_names] = talloc_move(*names, &names_nocache[i]);
>  					(*name_types)[*num_names] = name_types_nocache[i];
>  					(*num_names)++;
>  				}

Hmmm. I'd probably change "*names" to mem_ctx, there's no
real need for a heirarchy here, right ? You just want to
make sure both "names" and "(*names)[*num_names]" are
allocated from the passed in mem_ctx, correct ?

Jeremy.