svn commit: samba r23950 - in branches: SAMBA_3_2/source/lib/tdb/tools SAMBA_3_2_0/source/lib/tdb/tools SAMBA_4_0/source/lib/tdb/tools

obnox at samba.org obnox at samba.org
Wed Jul 18 08:29:01 GMT 2007


Author: obnox
Date: 2007-07-18 08:29:00 +0000 (Wed, 18 Jul 2007)
New Revision: 23950

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23950

Log:
unlink before rename is superfluous.

Michael


Modified:
   branches/SAMBA_3_2/source/lib/tdb/tools/tdbbackup.c
   branches/SAMBA_3_2_0/source/lib/tdb/tools/tdbbackup.c
   branches/SAMBA_4_0/source/lib/tdb/tools/tdbbackup.c


Changeset:
Modified: branches/SAMBA_3_2/source/lib/tdb/tools/tdbbackup.c
===================================================================
--- branches/SAMBA_3_2/source/lib/tdb/tools/tdbbackup.c	2007-07-18 08:19:50 UTC (rev 23949)
+++ branches/SAMBA_3_2/source/lib/tdb/tools/tdbbackup.c	2007-07-18 08:29:00 UTC (rev 23950)
@@ -177,7 +177,6 @@
 
 	/* close the new tdb and rename it to .bak */
 	tdb_close(tdb_new);
-	unlink(new_name);
 	if (rename(tmp_name, new_name) != 0) {
 		perror(new_name);
 		free(tmp_name);

Modified: branches/SAMBA_3_2_0/source/lib/tdb/tools/tdbbackup.c
===================================================================
--- branches/SAMBA_3_2_0/source/lib/tdb/tools/tdbbackup.c	2007-07-18 08:19:50 UTC (rev 23949)
+++ branches/SAMBA_3_2_0/source/lib/tdb/tools/tdbbackup.c	2007-07-18 08:29:00 UTC (rev 23950)
@@ -177,7 +177,6 @@
 
 	/* close the new tdb and rename it to .bak */
 	tdb_close(tdb_new);
-	unlink(new_name);
 	if (rename(tmp_name, new_name) != 0) {
 		perror(new_name);
 		free(tmp_name);

Modified: branches/SAMBA_4_0/source/lib/tdb/tools/tdbbackup.c
===================================================================
--- branches/SAMBA_4_0/source/lib/tdb/tools/tdbbackup.c	2007-07-18 08:19:50 UTC (rev 23949)
+++ branches/SAMBA_4_0/source/lib/tdb/tools/tdbbackup.c	2007-07-18 08:29:00 UTC (rev 23950)
@@ -177,7 +177,6 @@
 
 	/* close the new tdb and rename it to .bak */
 	tdb_close(tdb_new);
-	unlink(new_name);
 	if (rename(tmp_name, new_name) != 0) {
 		perror(new_name);
 		free(tmp_name);



More information about the samba-cvs mailing list