svn commit: samba r23884 - in branches: SAMBA_3_2/source/nsswitch SAMBA_3_2_0/source/nsswitch

vlendec at samba.org vlendec at samba.org
Mon Jul 16 07:46:30 GMT 2007


Author: vlendec
Date: 2007-07-16 07:46:29 +0000 (Mon, 16 Jul 2007)
New Revision: 23884

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23884

Log:
Fix Coverity ID 379
Modified:
   branches/SAMBA_3_2/source/nsswitch/winbindd_user.c
   branches/SAMBA_3_2_0/source/nsswitch/winbindd_user.c


Changeset:
Modified: branches/SAMBA_3_2/source/nsswitch/winbindd_user.c
===================================================================
--- branches/SAMBA_3_2/source/nsswitch/winbindd_user.c	2007-07-16 07:44:23 UTC (rev 23883)
+++ branches/SAMBA_3_2/source/nsswitch/winbindd_user.c	2007-07-16 07:46:29 UTC (rev 23884)
@@ -245,6 +245,12 @@
 		struct winbindd_domain *domain = NULL;
 		
 		domain = find_lookup_domain_from_sid(&s->user_sid);
+		if (domain == NULL) {
+			DEBUG(5, ("find_lookup_domain_from_sid(%s) failed\n",
+				  sid_string_static(&s->user_sid)));
+			request_error(s->state);
+			return;			
+		}
 		winbindd_lookup_name_by_sid(s->state->mem_ctx, domain,
 					    &s->user_sid, &domain_name,
 					    &user_name, &type );		

Modified: branches/SAMBA_3_2_0/source/nsswitch/winbindd_user.c
===================================================================
--- branches/SAMBA_3_2_0/source/nsswitch/winbindd_user.c	2007-07-16 07:44:23 UTC (rev 23883)
+++ branches/SAMBA_3_2_0/source/nsswitch/winbindd_user.c	2007-07-16 07:46:29 UTC (rev 23884)
@@ -245,6 +245,12 @@
 		struct winbindd_domain *domain = NULL;
 		
 		domain = find_lookup_domain_from_sid(&s->user_sid);
+		if (domain == NULL) {
+			DEBUG(5, ("find_lookup_domain_from_sid(%s) failed\n",
+				  sid_string_static(&s->user_sid)));
+			request_error(s->state);
+			return;			
+		}
 		winbindd_lookup_name_by_sid(s->state->mem_ctx, domain,
 					    &s->user_sid, &domain_name,
 					    &user_name, &type );		



More information about the samba-cvs mailing list