svn commit: samba r23744 - in branches: SAMBA_3_0/source/utils SAMBA_3_0_26/source/utils

obnox at samba.org obnox at samba.org
Sat Jul 7 20:41:01 GMT 2007


Author: obnox
Date: 2007-07-07 20:40:59 +0000 (Sat, 07 Jul 2007)
New Revision: 23744

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23744

Log:
Remove TODO-comment. lp_load returns False if opening
of the config file fails. That's enough of checking for
existence and readbility to my taste.

Michael


Modified:
   branches/SAMBA_3_0/source/utils/net_conf.c
   branches/SAMBA_3_0_26/source/utils/net_conf.c


Changeset:
Modified: branches/SAMBA_3_0/source/utils/net_conf.c
===================================================================
--- branches/SAMBA_3_0/source/utils/net_conf.c	2007-07-07 09:57:27 UTC (rev 23743)
+++ branches/SAMBA_3_0/source/utils/net_conf.c	2007-07-07 20:40:59 UTC (rev 23744)
@@ -690,8 +690,6 @@
 	DEBUG(3,("net_conf_import: reading configuration from file %s.\n",
 		filename));
 
-	/* TODO: check for existence and readability */
-
 	if (!lp_load(filename, 
 		     False,     /* global_only */
 		     True,      /* save_defaults */

Modified: branches/SAMBA_3_0_26/source/utils/net_conf.c
===================================================================
--- branches/SAMBA_3_0_26/source/utils/net_conf.c	2007-07-07 09:57:27 UTC (rev 23743)
+++ branches/SAMBA_3_0_26/source/utils/net_conf.c	2007-07-07 20:40:59 UTC (rev 23744)
@@ -690,8 +690,6 @@
 	DEBUG(3,("net_conf_import: reading configuration from file %s.\n",
 		filename));
 
-	/* TODO: check for existence and readability */
-
 	if (!lp_load(filename, 
 		     False,     /* global_only */
 		     True,      /* save_defaults */



More information about the samba-cvs mailing list