svn commit: samba r21018 - in branches: SAMBA_3_0/source/nsswitch SAMBA_3_0_24/source/nsswitch

gd at samba.org gd at samba.org
Thu Jan 25 14:08:45 GMT 2007


Author: gd
Date: 2007-01-25 14:08:45 +0000 (Thu, 25 Jan 2007)
New Revision: 21018

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=21018

Log:
Removing the set_domain_online_request again in trustdom_recv().

Jeremy, we really can't do that. There are setups with hundred and more
trusted domains out there, I have one customer who tells me it takes
more then half an hour for him after winbind is up and running. That
request registers the check_domain_online_handler which in turn forks
off the child immediately. Also discussed with Volker.

Guenther

Modified:
   branches/SAMBA_3_0/source/nsswitch/winbindd_util.c
   branches/SAMBA_3_0_24/source/nsswitch/winbindd_util.c


Changeset:
Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_util.c
===================================================================
--- branches/SAMBA_3_0/source/nsswitch/winbindd_util.c	2007-01-25 12:39:13 UTC (rev 21017)
+++ branches/SAMBA_3_0/source/nsswitch/winbindd_util.c	2007-01-25 14:08:45 UTC (rev 21018)
@@ -290,15 +290,6 @@
 						    &cache_methods,
 						    &sid);
 			setup_domain_child(domain, &domain->child, NULL);
-			if (!domain->internal) {
-				/* Even in the parent winbindd we'll need to
-				   talk to the DC, so try and see if we can
-				   contact it. Theoretically this isn't neccessary
-				   as the init_dc_connection() in init_child_recv()
-				   will do this, but we can start detecting the DC
-				   early here. */
-				set_domain_online_request(domain);
-			}
 		}
 		p=q;
 		if (p != NULL)

Modified: branches/SAMBA_3_0_24/source/nsswitch/winbindd_util.c
===================================================================
--- branches/SAMBA_3_0_24/source/nsswitch/winbindd_util.c	2007-01-25 12:39:13 UTC (rev 21017)
+++ branches/SAMBA_3_0_24/source/nsswitch/winbindd_util.c	2007-01-25 14:08:45 UTC (rev 21018)
@@ -290,15 +290,6 @@
 						    &cache_methods,
 						    &sid);
 			setup_domain_child(domain, &domain->child, NULL);
-			if (!domain->internal) {
-				/* Even in the parent winbindd we'll need to
-				   talk to the DC, so try and see if we can
-				   contact it. Theoretically this isn't neccessary
-				   as the init_dc_connection() in init_child_recv()
-				   will do this, but we can start detecting the DC
-				   early here. */
-				set_domain_online_request(domain);
-			}
 		}
 		p=q;
 		if (p != NULL)



More information about the samba-cvs mailing list