svn commit: samba r20708 - in branches/SAMBA_4_0/source/libnet: .

metze at samba.org metze at samba.org
Fri Jan 12 14:26:09 GMT 2007


Author: metze
Date: 2007-01-12 14:26:08 +0000 (Fri, 12 Jan 2007)
New Revision: 20708

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20708

Log:
fix crash bug! we can't use stack memory for async requests...

jelmer: please take more care when you fix pidl warnings:-)

metze
Modified:
   branches/SAMBA_4_0/source/libnet/libnet_become_dc.c


Changeset:
Modified: branches/SAMBA_4_0/source/libnet/libnet_become_dc.c
===================================================================
--- branches/SAMBA_4_0/source/libnet/libnet_become_dc.c	2007-01-12 14:16:30 UTC (rev 20707)
+++ branches/SAMBA_4_0/source/libnet/libnet_become_dc.c	2007-01-12 14:26:08 UTC (rev 20708)
@@ -1618,15 +1618,18 @@
 	struct composite_context *c = s->creq;
 	struct rpc_request *req;
 	struct drsuapi_DsGetNCChanges *r;
-	int32_t level;
 
 	r = talloc(s, struct drsuapi_DsGetNCChanges);
 	if (composite_nomem(r, c)) return;
 
-	r->in.level = &level;
+	r->in.level = talloc(r, int32_t);
+	if (composite_nomem(r->in.level, c)) return;
+	r->out.level = talloc(r, int32_t);
+	if (composite_nomem(r->out.level, c)) return;
+
 	r->in.bind_handle	= &drsuapi_h->bind_handle;
 	if (drsuapi_h->remote_info28.supported_extensions & DRSUAPI_SUPPORTED_EXTENSION_GETCHGREQ_V8) {
-		level				= 8;
+		*r->in.level				= 8;
 		r->in.req.req8.destination_dsa_guid	= partition->destination_dsa_guid;
 		r->in.req.req8.source_dsa_invocation_id	= partition->source_dsa_invocation_id;
 		r->in.req.req8.naming_context		= &partition->nc;
@@ -1642,7 +1645,7 @@
 		r->in.req.req8.mapping_ctr.num_mappings	= 0;
 		r->in.req.req8.mapping_ctr.mappings	= NULL;
 	} else {
-		level				= 5;
+		*r->in.level				= 5;
 		r->in.req.req5.destination_dsa_guid	= partition->destination_dsa_guid;
 		r->in.req.req5.source_dsa_invocation_id	= partition->source_dsa_invocation_id;
 		r->in.req.req5.naming_context		= &partition->nc;



More information about the samba-cvs mailing list