svn commit: samba r20620 - in branches/SAMBA_3_0_24/source/smbd: .

jra at samba.org jra at samba.org
Mon Jan 8 23:36:56 GMT 2007


Author: jra
Date: 2007-01-08 23:36:55 +0000 (Mon, 08 Jan 2007)
New Revision: 20620

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20620

Log:
This is definately needed - not sure about mapping to
BAD_PARAMETER if unlink is a wildcard but wildcard
unlinks are so rare in modern clients that doing what
W2K3 does is probably ok. OS/2 is the only client that
may care about this and hopefully we will get test coverage
from our wonderful OS/2 test team on this ! :-).
Jeremy.

Modified:
   branches/SAMBA_3_0_24/source/smbd/reply.c


Changeset:
Modified: branches/SAMBA_3_0_24/source/smbd/reply.c
===================================================================
--- branches/SAMBA_3_0_24/source/smbd/reply.c	2007-01-08 21:13:27 UTC (rev 20619)
+++ branches/SAMBA_3_0_24/source/smbd/reply.c	2007-01-08 23:36:55 UTC (rev 20620)
@@ -1995,6 +1995,11 @@
 	*directory = *mask = 0;
 	
 	rc = unix_convert(name,conn,0,&bad_path,&sbuf);
+	if (bad_path) {
+		return has_wild
+			? NT_STATUS_INVALID_PARAMETER
+			: NT_STATUS_OBJECT_PATH_NOT_FOUND;
+	}
 	
 	p = strrchr_m(name,'/');
 	if (!p) {



More information about the samba-cvs mailing list