svn commit: samba r20602 - in branches/SAMBA_3_0/source/smbd: .

vlendec at samba.org vlendec at samba.org
Mon Jan 8 08:00:53 GMT 2007


Author: vlendec
Date: 2007-01-08 08:00:53 +0000 (Mon, 08 Jan 2007)
New Revision: 20602

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20602

Log:
Fix coverity ID 339. SMB_ASSERT does not panic without -DDEVELOPER.

Volker

Modified:
   branches/SAMBA_3_0/source/smbd/notify.c


Changeset:
Modified: branches/SAMBA_3_0/source/smbd/notify.c
===================================================================
--- branches/SAMBA_3_0/source/smbd/notify.c	2007-01-08 04:58:04 UTC (rev 20601)
+++ branches/SAMBA_3_0/source/smbd/notify.c	2007-01-08 08:00:53 UTC (rev 20602)
@@ -219,8 +219,11 @@
 			break;
 		}
 	}
-	SMB_ASSERT(req != NULL);
 
+	if (req == NULL) {
+		smb_panic("notify_req not found in fsp's requests\n");
+	}
+
 	DLIST_REMOVE(fsp->notify->requests, req);
 	DLIST_REMOVE(notify_changes_by_mid, req->mid_map);
 	SAFE_FREE(req->mid_map);



More information about the samba-cvs mailing list