svn commit: samba r20532 - in branches: SAMBA_3_0/source/smbd SAMBA_3_0_24/source/smbd

jra at samba.org jra at samba.org
Thu Jan 4 22:01:37 GMT 2007


Author: jra
Date: 2007-01-04 22:01:36 +0000 (Thu, 04 Jan 2007)
New Revision: 20532

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20532

Log:
>From Volker...

"smbcli_setattr("") always returns ACCESS_DENIED, test extension to follow.

Merge to 3.0.24?"

Yep (with slight optimization).

Jeremy.

Modified:
   branches/SAMBA_3_0/source/smbd/reply.c
   branches/SAMBA_3_0_24/source/smbd/reply.c


Changeset:
Modified: branches/SAMBA_3_0/source/smbd/reply.c
===================================================================
--- branches/SAMBA_3_0/source/smbd/reply.c	2007-01-04 21:09:29 UTC (rev 20531)
+++ branches/SAMBA_3_0/source/smbd/reply.c	2007-01-04 22:01:36 UTC (rev 20532)
@@ -1004,7 +1004,7 @@
 		return ERROR_NT(NT_STATUS_OBJECT_PATH_NOT_FOUND);
 	}
 
-	if (strequal(fname, ".")) {
+	if (fname[0] == '.' && fname[1] == '\0') {
 		/*
 		 * Not sure here is the right place to catch this
 		 * condition. Might be moved to somewhere else later -- vl

Modified: branches/SAMBA_3_0_24/source/smbd/reply.c
===================================================================
--- branches/SAMBA_3_0_24/source/smbd/reply.c	2007-01-04 21:09:29 UTC (rev 20531)
+++ branches/SAMBA_3_0_24/source/smbd/reply.c	2007-01-04 22:01:36 UTC (rev 20532)
@@ -1004,6 +1004,15 @@
 		return ERROR_NT(NT_STATUS_OBJECT_PATH_NOT_FOUND);
 	}
 
+	if (fname[0] == '.' && fname[1] == '\0') {
+		/*
+		 * Not sure here is the right place to catch this
+		 * condition. Might be moved to somewhere else later -- vl
+		 */
+		END_PROFILE(SMBsetatr);
+		return ERROR_NT(NT_STATUS_ACCESS_DENIED);
+	}
+
 	mode = SVAL(inbuf,smb_vwv0);
 	mtime = srv_make_unix_date3(inbuf+smb_vwv1);
   



More information about the samba-cvs mailing list