svn commit: samba r21558 - in branches: SAMBA_3_0/source/libads SAMBA_3_0_25/source/libads

gd at samba.org gd at samba.org
Tue Feb 27 13:31:42 GMT 2007


Author: gd
Date: 2007-02-27 13:31:42 +0000 (Tue, 27 Feb 2007)
New Revision: 21558

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=21558

Log:
Safe more indent, again no code changes.

Guenther

Modified:
   branches/SAMBA_3_0/source/libads/kerberos_verify.c
   branches/SAMBA_3_0_25/source/libads/kerberos_verify.c


Changeset:
Modified: branches/SAMBA_3_0/source/libads/kerberos_verify.c
===================================================================
--- branches/SAMBA_3_0/source/libads/kerberos_verify.c	2007-02-27 13:27:31 UTC (rev 21557)
+++ branches/SAMBA_3_0/source/libads/kerberos_verify.c	2007-02-27 13:31:42 UTC (rev 21558)
@@ -96,44 +96,44 @@
 			goto out;
 		}
 
-		for (i = 0; i < sizeof(valid_princ_formats) / sizeof(valid_princ_formats[0]); i++) {
-			if (strequal(entry_princ_s, valid_princ_formats[i])) {
-				number_matched_principals++;
-				p_packet->length = ticket->length;
-				p_packet->data = (char *)ticket->data;
-				*pp_tkt = NULL;
+		for (i = 0; i < ARRAY_SIZE(valid_princ_formats); i++) {
 
-				ret = krb5_rd_req_return_keyblock_from_keytab(context, &auth_context, p_packet,
-								  	      kt_entry.principal, keytab,
-									      NULL, pp_tkt, keyblock);
+			if (!strequal(entry_princ_s, valid_princ_formats[i])) {
+				continue;
+			}
 
-				if (ret) {
-					DEBUG(10,("ads_keytab_verify_ticket: "
-						"krb5_rd_req_return_keyblock_from_keytab(%s) failed: %s\n",
-						entry_princ_s, error_message(ret)));
+			number_matched_principals++;
+			p_packet->length = ticket->length;
+			p_packet->data = (char *)ticket->data;
+			*pp_tkt = NULL;
 
-					/* workaround for MIT: 
-					 * as krb5_ktfile_get_entry will
-					 * explicitly close the
-					 * krb5_keytab as soon as
-					 * krb5_rd_req has sucessfully
-					 * decrypted the ticket but the
-					 * ticket is not valid yet (due
-					 * to clockskew) there is no
-					 * point in querying more
-					 * keytab entries - Guenther */
-						
-					if (ret == KRB5KRB_AP_ERR_TKT_NYV || 
-					    ret == KRB5KRB_AP_ERR_TKT_EXPIRED) {
-						break;
-					}
-				} else {
-					DEBUG(3,("ads_keytab_verify_ticket: "
-						"krb5_rd_req_return_keyblock_from_keytab succeeded for principal %s\n",
-						entry_princ_s));
-					auth_ok = True;
+			ret = krb5_rd_req_return_keyblock_from_keytab(context, &auth_context, p_packet,
+							  	      kt_entry.principal, keytab,
+								      NULL, pp_tkt, keyblock);
+
+			if (ret) {
+				DEBUG(10,("ads_keytab_verify_ticket: "
+					"krb5_rd_req_return_keyblock_from_keytab(%s) failed: %s\n",
+					entry_princ_s, error_message(ret)));
+
+				/* workaround for MIT: 
+				* as krb5_ktfile_get_entry will explicitly
+				* close the krb5_keytab as soon as krb5_rd_req
+				* has sucessfully decrypted the ticket but the
+				* ticket is not valid yet (due to clockskew)
+				* there is no point in querying more keytab
+				* entries - Guenther */
+					
+				if (ret == KRB5KRB_AP_ERR_TKT_NYV || 
+				    ret == KRB5KRB_AP_ERR_TKT_EXPIRED) {
 					break;
 				}
+			} else {
+				DEBUG(3,("ads_keytab_verify_ticket: "
+					"krb5_rd_req_return_keyblock_from_keytab succeeded for principal %s\n",
+					entry_princ_s));
+				auth_ok = True;
+				break;
 			}
 		}
 
@@ -150,7 +150,7 @@
 
   out:
 	
-	for (i = 0; i < sizeof(valid_princ_formats) / sizeof(valid_princ_formats[0]); i++) {
+	for (i = 0; i < ARRAY_SIZE(valid_princ_formats); i++) {
 		SAFE_FREE(valid_princ_formats[i]);
 	}
 	

Modified: branches/SAMBA_3_0_25/source/libads/kerberos_verify.c
===================================================================
--- branches/SAMBA_3_0_25/source/libads/kerberos_verify.c	2007-02-27 13:27:31 UTC (rev 21557)
+++ branches/SAMBA_3_0_25/source/libads/kerberos_verify.c	2007-02-27 13:31:42 UTC (rev 21558)
@@ -96,44 +96,44 @@
 			goto out;
 		}
 
-		for (i = 0; i < sizeof(valid_princ_formats) / sizeof(valid_princ_formats[0]); i++) {
-			if (strequal(entry_princ_s, valid_princ_formats[i])) {
-				number_matched_principals++;
-				p_packet->length = ticket->length;
-				p_packet->data = (char *)ticket->data;
-				*pp_tkt = NULL;
+		for (i = 0; i < ARRAY_SIZE(valid_princ_formats); i++) {
 
-				ret = krb5_rd_req_return_keyblock_from_keytab(context, &auth_context, p_packet,
-								  	      kt_entry.principal, keytab,
-									      NULL, pp_tkt, keyblock);
+			if (!strequal(entry_princ_s, valid_princ_formats[i])) {
+				continue;
+			}
 
-				if (ret) {
-					DEBUG(10,("ads_keytab_verify_ticket: "
-						"krb5_rd_req_return_keyblock_from_keytab(%s) failed: %s\n",
-						entry_princ_s, error_message(ret)));
+			number_matched_principals++;
+			p_packet->length = ticket->length;
+			p_packet->data = (char *)ticket->data;
+			*pp_tkt = NULL;
 
-					/* workaround for MIT: 
-					 * as krb5_ktfile_get_entry will
-					 * explicitly close the
-					 * krb5_keytab as soon as
-					 * krb5_rd_req has sucessfully
-					 * decrypted the ticket but the
-					 * ticket is not valid yet (due
-					 * to clockskew) there is no
-					 * point in querying more
-					 * keytab entries - Guenther */
-						
-					if (ret == KRB5KRB_AP_ERR_TKT_NYV || 
-					    ret == KRB5KRB_AP_ERR_TKT_EXPIRED) {
-						break;
-					}
-				} else {
-					DEBUG(3,("ads_keytab_verify_ticket: "
-						"krb5_rd_req_return_keyblock_from_keytab succeeded for principal %s\n",
-						entry_princ_s));
-					auth_ok = True;
+			ret = krb5_rd_req_return_keyblock_from_keytab(context, &auth_context, p_packet,
+							  	      kt_entry.principal, keytab,
+								      NULL, pp_tkt, keyblock);
+
+			if (ret) {
+				DEBUG(10,("ads_keytab_verify_ticket: "
+					"krb5_rd_req_return_keyblock_from_keytab(%s) failed: %s\n",
+					entry_princ_s, error_message(ret)));
+
+				/* workaround for MIT: 
+				* as krb5_ktfile_get_entry will explicitly
+				* close the krb5_keytab as soon as krb5_rd_req
+				* has sucessfully decrypted the ticket but the
+				* ticket is not valid yet (due to clockskew)
+				* there is no point in querying more keytab
+				* entries - Guenther */
+					
+				if (ret == KRB5KRB_AP_ERR_TKT_NYV || 
+				    ret == KRB5KRB_AP_ERR_TKT_EXPIRED) {
 					break;
 				}
+			} else {
+				DEBUG(3,("ads_keytab_verify_ticket: "
+					"krb5_rd_req_return_keyblock_from_keytab succeeded for principal %s\n",
+					entry_princ_s));
+				auth_ok = True;
+				break;
 			}
 		}
 
@@ -150,7 +150,7 @@
 
   out:
 	
-	for (i = 0; i < sizeof(valid_princ_formats) / sizeof(valid_princ_formats[0]); i++) {
+	for (i = 0; i < ARRAY_SIZE(valid_princ_formats); i++) {
 		SAFE_FREE(valid_princ_formats[i]);
 	}
 	



More information about the samba-cvs mailing list